Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2157373002: Fix cctest/test-code-stubs-mips64/ConvertDToI failure on big-endian architectures (Closed)

Created:
4 years, 5 months ago by ivica.bogosavljevic
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer, v8-mips-ports
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix cctest/test-code-stubs-mips64/ConvertDToI failure on big-endian architectures Failure is due to different endianness on big endian. The test now passes on both big-endian and little-endian architectures. TEST=cctest/test-code-stubs-mips64/ConvertDToI BUG= Committed: https://crrev.com/5d8094ee794412ad9a724ed473831887be5a85f1 Cr-Commit-Position: refs/heads/master@{#38022}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M test/cctest/test-code-stubs.cc View 2 chunks +12 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
ivica.bogosavljevic
PTAL
4 years, 5 months ago (2016-07-19 12:27:42 UTC) #2
ivica.bogosavljevic
Reminder...
4 years, 5 months ago (2016-07-25 12:20:22 UTC) #3
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-07-25 12:41:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157373002/1
4 years, 5 months ago (2016-07-25 13:24:15 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-25 13:25:32 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-25 13:27:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5d8094ee794412ad9a724ed473831887be5a85f1
Cr-Commit-Position: refs/heads/master@{#38022}

Powered by Google App Engine
This is Rietveld 408576698