Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Issue 2157363004: Fix SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure to not leak test state (Closed)

Created:
4 years, 5 months ago by raymes
Modified:
4 years, 5 months ago
Reviewers:
kinuko, Lei Zhang
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure to not leak test state SecureOriginWhiteListTest.UnsafelyTreatInsecureOriginAsSecure currently marks 2 insecure origins as secure. This state leaks to other tests such that those origins are treated as secure in those tests. This CL cleans up the state by resetting SchemeAndOriginWhitelist after the test. BUG=629499 Committed: https://crrev.com/d0dfe00f7e138a1f9221e8865fffe3b3a859c92f Cr-Commit-Position: refs/heads/master@{#406733}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -3 lines) Patch
M chrome/common/secure_origin_whitelist_unittest.cc View 2 chunks +11 lines, -3 lines 0 comments Download
M content/common/origin_util.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (12 generated)
raymes
4 years, 5 months ago (2016-07-20 02:56:19 UTC) #3
kinuko
lgtm, thanks
4 years, 5 months ago (2016-07-20 08:04:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157363004/1
4 years, 5 months ago (2016-07-20 22:45:52 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/221828)
4 years, 5 months ago (2016-07-20 22:54:55 UTC) #12
raymes
+thestig for chrome/ OWNERS
4 years, 5 months ago (2016-07-21 00:38:03 UTC) #14
Lei Zhang
lgtm, glad you found the bomb.
4 years, 5 months ago (2016-07-21 00:49:16 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157363004/1
4 years, 5 months ago (2016-07-21 00:53:03 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 00:58:50 UTC) #19
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 01:00:28 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d0dfe00f7e138a1f9221e8865fffe3b3a859c92f
Cr-Commit-Position: refs/heads/master@{#406733}

Powered by Google App Engine
This is Rietveld 408576698