Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1168)

Issue 2157363003: [stubs] Suppress shifts with immediate shift of zero. (Closed)

Created:
4 years, 5 months ago by oth
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Suppress shift by zero. LOG=N BUG= Committed: https://crrev.com/ac69e74fbf8187d09e43596fa49a931185f4e323 Cr-Commit-Position: refs/heads/master@{#37886}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
oth
Benedikt, PTAL. I noticed when inlining the common case of ForInPrepare that we're emitting shifts ...
4 years, 5 months ago (2016-07-19 13:41:16 UTC) #2
Benedikt Meurer
LGTM. Thanks.
4 years, 5 months ago (2016-07-20 03:46:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157363003/1
4 years, 5 months ago (2016-07-20 08:04:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 08:07:09 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 08:08:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac69e74fbf8187d09e43596fa49a931185f4e323
Cr-Commit-Position: refs/heads/master@{#37886}

Powered by Google App Engine
This is Rietveld 408576698