Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Issue 2157283002: DevTools: remove WI.SourcesView._currentUISourceCode (Closed)

Created:
4 years, 5 months ago by lushnikov
Modified:
4 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove WI.SourcesView._currentUISourceCode Since WI.SourcesView._currentUISourceCode duplicates the currentFile value inside WI.TabbedEditorContainer, there's no need for it. BUG=none R=pfeldman, dgozman Committed: https://crrev.com/7696faffa666a01e794069fd06d8156782f9cb72 Cr-Commit-Position: refs/heads/master@{#406328}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 7 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
lushnikov
please, take a look
4 years, 5 months ago (2016-07-19 01:56:52 UTC) #1
dgozman
Please follow up with the strange state we discussed offline. lgtm
4 years, 5 months ago (2016-07-19 18:27:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157283002/1
4 years, 5 months ago (2016-07-19 18:28:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 18:37:10 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 18:37:19 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:39:37 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7696faffa666a01e794069fd06d8156782f9cb72
Cr-Commit-Position: refs/heads/master@{#406328}

Powered by Google App Engine
This is Rietveld 408576698