Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2157243003:
Allow Chrome on Windows to draw at 1.25 device scale factor. (Closed)
DescriptionAllow Chrome on Windows to draw at 1.25 device scale factor.
BUG=410696
Committed: https://crrev.com/9ab8b8c345e668ae0932c162810604ea4eb7bc42
Cr-Commit-Position: refs/heads/master@{#406437}
Patch Set 1 #
Total comments: 3
Patch Set 2 : update screen_win_unittest #Patch Set 3 : tiny edits #
Total comments: 2
Patch Set 4 : remove comment #
Total comments: 3
Patch Set 5 : fix GetDisplayNearestPoint #
Messages
Total messages: 29 (14 generated)
The CQ bit was checked by bsep@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 ========== to ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 ==========
bsep@chromium.org changed reviewers: + oshima@chromium.org
https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc File ui/display/win/dpi.cc (right): https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc#newco... ui/display/win/dpi.cc:54: return GetUnforcedDeviceScaleFactor(); will this enable other values like 1.1 ? If so, you probably want to double check if it looks ok.
robliao@chromium.org changed reviewers: + robliao@chromium.org
https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc File ui/display/win/dpi.cc (left): https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc#oldco... ui/display/win/dpi.cc:55: return (dpi_scale <= 1.25f) ? 1.f : dpi_scale; Update the ScreenWin unit tests to allow for the new 1-1.25 scales.
On 2016/07/18 23:51:34, oshima wrote: > https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc > File ui/display/win/dpi.cc (right): > > https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc#newco... > ui/display/win/dpi.cc:54: return GetUnforcedDeviceScaleFactor(); > will this enable other values like 1.1 ? If so, you probably want to double > check if it looks ok. Hypothetically it will allow them, but those aren't settable via the UI so I'm not worried about them.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc File ui/display/win/dpi.cc (left): https://codereview.chromium.org/2157243003/diff/1/ui/display/win/dpi.cc#oldco... ui/display/win/dpi.cc:55: return (dpi_scale <= 1.25f) ? 1.f : dpi_scale; On 2016/07/18 23:53:40, robliao wrote: > Update the ScreenWin unit tests to allow for the new 1-1.25 scales. Done.
lgtm + comment https://codereview.chromium.org/2157243003/diff/40001/ui/display/win/screen_w... File ui/display/win/screen_win_unittest.cc (right): https://codereview.chromium.org/2157243003/diff/40001/ui/display/win/screen_w... ui/display/win/screen_win_unittest.cc:393: // Add Monitor of Scale Factor 1.0 since 1.25 is clamped to 1.0. Remove this comment as well.
https://codereview.chromium.org/2157243003/diff/40001/ui/display/win/screen_w... File ui/display/win/screen_win_unittest.cc (right): https://codereview.chromium.org/2157243003/diff/40001/ui/display/win/screen_w... ui/display/win/screen_win_unittest.cc:393: // Add Monitor of Scale Factor 1.0 since 1.25 is clamped to 1.0. On 2016/07/19 19:12:33, robliao wrote: > Remove this comment as well. Done.
The CQ bit was checked by bsep@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org Link to the patchset: https://codereview.chromium.org/2157243003/#ps60001 (title: "remove comment")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
https://codereview.chromium.org/2157243003/diff/60001/ui/display/win/screen_w... File ui/display/win/screen_win_unittest.cc (right): https://codereview.chromium.org/2157243003/diff/60001/ui/display/win/screen_w... ui/display/win/screen_win_unittest.cc:515: EXPECT_EQ(display, screen->GetDisplayNearestPoint(gfx::Point(0, 0))); Ah, these need to be updated as well. https://codereview.chromium.org/2157243003/diff/60001/ui/display/win/screen_w... ui/display/win/screen_win_unittest.cc:525: screen->GetDisplayMatching(gfx::Rect(1819, 1099, 100, 100))); FYI, this can say the same because GetDisplayMatching takes screen coordinates (as opposed to DIP coordinates).
https://codereview.chromium.org/2157243003/diff/60001/ui/display/win/screen_w... File ui/display/win/screen_win_unittest.cc (right): https://codereview.chromium.org/2157243003/diff/60001/ui/display/win/screen_w... ui/display/win/screen_win_unittest.cc:515: EXPECT_EQ(display, screen->GetDisplayNearestPoint(gfx::Point(0, 0))); On 2016/07/19 23:55:11, robliao wrote: > Ah, these need to be updated as well. Done.
The CQ bit was checked by bsep@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from robliao@chromium.org Link to the patchset: https://codereview.chromium.org/2157243003/#ps80001 (title: "fix GetDisplayNearestPoint")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 ========== to ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
CQ bit was unchecked.
Message was sent while issue was closed.
Description was changed from ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 ========== to ========== Allow Chrome on Windows to draw at 1.25 device scale factor. BUG=410696 Committed: https://crrev.com/9ab8b8c345e668ae0932c162810604ea4eb7bc42 Cr-Commit-Position: refs/heads/master@{#406437} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/9ab8b8c345e668ae0932c162810604ea4eb7bc42 Cr-Commit-Position: refs/heads/master@{#406437} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
