Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: net/base/net_util.h

Issue 21572002: Add UMA entry for intranet SSL warnings (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Needed to move the unit tests as well Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/base/net_util.h
diff --git a/net/base/net_util.h b/net/base/net_util.h
index 4d6f9ebbb17fb4f2999de01df21616fbf223b004..c532679fcc1aead5b16c4a69f724e4c2429e71e9 100644
--- a/net/base/net_util.h
+++ b/net/base/net_util.h
@@ -111,6 +111,17 @@ NET_EXPORT std::string GetHostAndPort(const GURL& url);
// if it is the default for the URL's scheme.
NET_EXPORT_PRIVATE std::string GetHostAndOptionalPort(const GURL& url);
+// Returns true if |hostname| contains a name that is non-unique among
+// certificates (eg: an "internal server name").
Ryan Sleevi 2013/08/01 21:37:55 nit: Probably need to update this comment to remov
felt 2013/08/01 22:00:25 Most of the comment is in the implementation file
+//
+// While such names are not scheduled to be deprecated until 1 November 2015
+// according to the CA/Browser Forum Baseline Requirements (v1.1), they
+// represent a real risk for the deployment of new gTLDs, and thus being
+// phased out ahead of the hard deadline.
+// TODO(rsleevi): http://crbug.com/119212 - Also match internal IP address
+// ranges.
+NET_EXPORT bool IsHostnameNonUnique(const std::string& hostname);
+
// Convenience struct for when you need a |struct sockaddr|.
struct SockaddrStorage {
SockaddrStorage() : addr_len(sizeof(addr_storage)),

Powered by Google App Engine
This is Rietveld 408576698