 Chromium Code Reviews
 Chromium Code Reviews Issue 21572002:
  Add UMA entry for intranet SSL warnings  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src
    
  
    Issue 21572002:
  Add UMA entry for intranet SSL warnings  (Closed) 
  Base URL: svn://svn.chromium.org/chrome/trunk/src| Index: net/cert/cert_verify_proc.h | 
| diff --git a/net/cert/cert_verify_proc.h b/net/cert/cert_verify_proc.h | 
| index 4feae19182551e01de6c6e1d22e7e78e50a758f6..581519f60d8b6666584dbde2ec6aedc7fc3260b2 100644 | 
| --- a/net/cert/cert_verify_proc.h | 
| +++ b/net/cert/cert_verify_proc.h | 
| @@ -66,6 +66,17 @@ class NET_EXPORT CertVerifyProc | 
| // passed to Verify() is ignored when this returns false. | 
| virtual bool SupportsAdditionalTrustAnchors() const = 0; | 
| + // Returns true if |hostname| contains a name that is non-unique among | 
| + // certificates (eg: an "internal server name"). | 
| + // | 
| + // While such names are not scheduled to be deprecated until 1 November 2015 | 
| + // according to the CA/Browser Forum Baseline Requirements (v1.1), they | 
| + // represent a real risk for the deployment of new gTLDs, and thus being | 
| + // phased out ahead of the hard deadline. | 
| + // TODO(rsleevi): http://crbug.com/119212 - Also match internal IP address | 
| + // ranges. | 
| + static bool IsHostnameNonUnique(const std::string& hostname); | 
| 
Ryan Sleevi
2013/08/01 19:03:55
I don't know what happened, but my original commen
 
felt
2013/08/01 20:32:22
Done, moved it over.
 | 
| + | 
| protected: | 
| CertVerifyProc(); | 
| virtual ~CertVerifyProc(); | 
| @@ -91,17 +102,6 @@ class NET_EXPORT CertVerifyProc | 
| // are hashes of SubjectPublicKeyInfo structures) is explicitly blocked. | 
| static bool IsPublicKeyBlacklisted(const HashValueVector& public_key_hashes); | 
| - // Returns true if |hostname| contains a name that is non-unique among | 
| - // certificates (eg: an "internal server name"). | 
| - // | 
| - // While such names are not scheduled to be deprecated until 1 November 2015 | 
| - // according to the CA/Browser Forum Baseline Requirements (v1.1), they | 
| - // represent a real risk for the deployment of new gTLDs, and thus being | 
| - // phased out ahead of the hard deadline. | 
| - // TODO(rsleevi): http://crbug.com/119212 - Also match internal IP address | 
| - // ranges. | 
| - static bool IsHostnameNonUnique(const std::string& hostname); | 
| - | 
| DISALLOW_COPY_AND_ASSIGN(CertVerifyProc); | 
| }; |