Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp

Issue 2157173002: Fix PaintPropertyTreePrinter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
index da375e28bbfba07d67c4cacc091ca68ce813d696..1d96b57785d5fc04be87268a3c23c8ee6dff19cb 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp
@@ -86,10 +86,12 @@ class PropertyTreePrinterTraits<TransformPaintPropertyNode> {
public:
static void addFrameViewProperties(const FrameView& frameView, PropertyTreePrinter<TransformPaintPropertyNode>& printer)
{
+ if (const TransformPaintPropertyNode* rootTransform = frameView.rootTransform())
+ printer.addPropertyNode(rootTransform, "RootTransform (FrameView)");
if (const TransformPaintPropertyNode* preTranslation = frameView.preTranslation())
- printer.addPropertyNode(preTranslation, String("PreTranslation (FrameView)"));
+ printer.addPropertyNode(preTranslation, "PreTranslation (FrameView)");
if (const TransformPaintPropertyNode* scrollTranslation = frameView.scrollTranslation())
- printer.addPropertyNode(scrollTranslation, String("ScrollTranslation (FrameView)"));
+ printer.addPropertyNode(scrollTranslation, "ScrollTranslation (FrameView)");
}
static void addObjectPaintProperties(const LayoutObject& object, const ObjectPaintProperties& paintProperties, PropertyTreePrinter<TransformPaintPropertyNode>& printer)
@@ -134,6 +136,8 @@ class PropertyTreePrinterTraits<ClipPaintPropertyNode> {
public:
static void addFrameViewProperties(const FrameView& frameView, PropertyTreePrinter<ClipPaintPropertyNode>& printer)
{
+ if (const ClipPaintPropertyNode* rootClip = frameView.rootClip())
+ printer.addPropertyNode(rootClip, "RootClip (FrameView)");
if (const ClipPaintPropertyNode* contentClip = frameView.contentClip())
printer.addPropertyNode(contentClip, "ContentClip (FrameView)");
}
@@ -162,7 +166,8 @@ class PropertyTreePrinterTraits<EffectPaintPropertyNode> {
public:
static void addFrameViewProperties(const FrameView& frameView, PropertyTreePrinter<EffectPaintPropertyNode>& printer)
{
- // FrameView does not create any effect nodes.
+ if (const EffectPaintPropertyNode* rootEffect = frameView.rootEffect())
+ printer.addPropertyNode(rootEffect, "RootEffect (FrameView)");
}
static void addObjectPaintProperties(const LayoutObject& object, const ObjectPaintProperties& paintProperties, PropertyTreePrinter<EffectPaintPropertyNode>& printer)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698