chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h - Issue 2157153003: Call WillStartRequestForTesting in TestRenderFrameHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h

Issue 2157153003: Call WillStartRequestForTesting in TestRenderFrameHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Just null check nav handle Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chrome_content_browser_client.cc ('k') | chrome/browser/chromeos/login/signin/merge_session_throttling_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h

diff --git a/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h b/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h

index f3d0fd4cac27f1329c6baf6550f6fa9b5b6bff8b..e1227dabeb056d4098616b6c66f9848a2c49837b 100644

--- a/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h

+++ b/chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h

@@ -25,6 +25,11 @@ namespace merge_session_throttling_utils {

// page load.

using CompletionCallback = base::Closure;

+// Policy for when it is valid to attach a MergeSessionNavigationThrottle.

+// Namely, this will be false for unit tests, where the UserManager is not

+// initialized.

+bool ShouldAttachNavigationThrottle();

// Checks if session is already merged. This is safe to call on all threads.

bool AreAllSessionMergedAlready();