chrome/browser/chrome_content_browser_client.cc - Issue 2157153003: Call WillStartRequestForTesting in TestRenderFrameHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2157153003: Call WillStartRequestForTesting in TestRenderFrameHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Thread transition and docuemnt ShouldAttachNavigationThrottle Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index 3db8ffcf93b9f72ec2566445f896cd012b3901ac..78e601432069b9cb0c19ba47216fd86ee9d06825 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -2942,7 +2942,8 @@ ChromeContentBrowserClient::CreateThrottlesForNavigation(

// Add interstitial page while merge session process (cookie reconstruction

// from OAuth2 refresh token in ChromeOS login) is still in progress while

// we are attempting to load a google property.

- if (!merge_session_throttling_utils::AreAllSessionMergedAlready() &&

+ if (merge_session_throttling_utils::ShouldAttachNavigationThrottle() &&

+ !merge_session_throttling_utils::AreAllSessionMergedAlready() &&

handle->GetURL().SchemeIsHTTPOrHTTPS()) {

throttles.push_back(MergeSessionNavigationThrottle::Create(handle));

}

« no previous file with comments | « no previous file | chrome/browser/chromeos/login/signin/merge_session_throttling_utils.h » ('j') | content/test/test_render_frame_host.cc » ('J')