Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 2157153002: Remove WebContents::InsertCSS since it is unused (Closed)

Created:
4 years, 5 months ago by Mostyn Bramley-Moore
Modified:
4 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WebContents::InsertCSS since it is unused This looks like it hasn't been used since CL923463003 landed over a year ago. BUG=331654 Committed: https://crrev.com/dfd827c16f72da9b85b01d4a6d577e69324ec4ad Cr-Commit-Position: refs/heads/master@{#406656}

Patch Set 1 #

Patch Set 2 : remove java entry points #

Patch Set 3 : remove jni stub #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -40 lines) Patch
M content/browser/web_contents/web_contents_android.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_android.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/webcontents/WebContentsImpl.java View 1 2 2 chunks +0 lines, -7 lines 0 comments Download
M content/public/android/java/src/org/chromium/content_public/browser/WebContents.java View 1 1 chunk +0 lines, -5 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +0 lines, -3 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_frame_impl.cc View 2 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 32 (20 generated)
esprehn
4 years, 5 months ago (2016-07-19 09:00:04 UTC) #12
esprehn
4 years, 5 months ago (2016-07-19 09:01:20 UTC) #15
David Trainor- moved to gerrit
lgtm thanks! :)
4 years, 5 months ago (2016-07-19 14:51:21 UTC) #17
Mostyn Bramley-Moore
@Jochen: can you please give this content/OWNERS approval?
4 years, 5 months ago (2016-07-19 18:13:52 UTC) #19
jochen (gone - plz use gerrit)
lgtm
4 years, 5 months ago (2016-07-20 10:55:10 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157153002/40001
4 years, 5 months ago (2016-07-20 11:16:57 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/221352)
4 years, 5 months ago (2016-07-20 11:26:10 UTC) #24
Mostyn Bramley-Moore
@Will: can you please take a look at content/common/frame_messages.h ?
4 years, 5 months ago (2016-07-20 11:40:39 UTC) #26
Will Harris
content/common/frame_messages.h lgtm
4 years, 5 months ago (2016-07-20 19:29:25 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157153002/40001
4 years, 5 months ago (2016-07-20 19:31:10 UTC) #29
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-07-20 20:34:54 UTC) #30
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 20:36:46 UTC) #32
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/dfd827c16f72da9b85b01d4a6d577e69324ec4ad
Cr-Commit-Position: refs/heads/master@{#406656}

Powered by Google App Engine
This is Rietveld 408576698