Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1593)

Issue 2157143003: Remove slow test for connecting to the AD DC server. (Closed)

Created:
4 years, 5 months ago by pastarmovj
Modified:
4 years, 5 months ago
Reviewers:
rkaplow, Georges Khalil, rkaplow
CC:
chromium-reviews, asvitkine+watch_chromium.org, Georges Khalil
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove slow test for connecting to the AD DC server. DsBind was slowing down Chrome startup blocking the file thread for up to a few minutes on some machines. This check is not really delivering any more useful information to us so it can be safely removed. BUG=621270 TEST=none Committed: https://crrev.com/f34984bbeee68c231b5ad17464ad8ea41f1f0d09 Cr-Commit-Position: refs/heads/master@{#406373}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -16 lines) Patch
M components/policy/core/common/policy_loader_win.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +11 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
pastarmovj
4 years, 5 months ago (2016-07-19 15:30:15 UTC) #2
pastarmovj
Hi, please review this change which deprecates two UMA stats that are not needed anymore.
4 years, 5 months ago (2016-07-19 15:31:02 UTC) #3
rkaplow
lgtm
4 years, 5 months ago (2016-07-19 20:21:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157143003/1
4 years, 5 months ago (2016-07-19 20:30:07 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 20:36:56 UTC) #12
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 20:37:04 UTC) #13
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 20:40:19 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f34984bbeee68c231b5ad17464ad8ea41f1f0d09
Cr-Commit-Position: refs/heads/master@{#406373}

Powered by Google App Engine
This is Rietveld 408576698