Move didFocus from WebWidgetClient to WebViewClient.

Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
Committed: https://crrev.com/09e6b3be2036c2cfbdc625fc06bc928a8c22c60a
Cr-Commit-Position: refs/heads/master@{#406609}

[lfg, 2016-07-18 20:10:04]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 20:11:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[lfg, 2016-07-18 20:46:33]

lfg@chromium.org changed reviewers:
+ dcheng@chromium.org

[lfg, 2016-07-18 20:46:34]

PTAL.

[commit-bot: I haz the power, 2016-07-19 01:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 01:54:23]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-07-19 13:51:14]

LGTM. Does this message already work correctly if the main frame is remote?

https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
File content/renderer/render_widget.h (left):

https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
content/renderer/render_widget.h:238: void didFocus() override;
We should probably update the comment in render_view_impl.h for didFocus as
well.

[lfg, 2016-07-19 13:58:02]

Description was changed from

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[lfg, 2016-07-19 14:01:00]

On 2016/07/19 13:51:14, dcheng wrote:
> LGTM. Does this message already work correctly if the main frame is remote?

Yes, it does. RenderView does not handle it, it's always delegated to the
WebContents, so
there's not work that needs to be done there.

>
https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
> File content/renderer/render_widget.h (left):
> 
>
https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
> content/renderer/render_widget.h:238: void didFocus() override;
> We should probably update the comment in render_view_impl.h for didFocus as
> well.

Which comment are you referring to? I've moved it to the WebViewClient
implementation section.

[dcheng, 2016-07-19 14:49:50]

On 2016/07/19 14:01:00, lfg wrote:
> On 2016/07/19 13:51:14, dcheng wrote:
> > LGTM. Does this message already work correctly if the main frame is remote?
> 
> Yes, it does. RenderView does not handle it, it's always delegated to the
> WebContents, so
> there's not work that needs to be done there.
> 
> >
>
https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
> > File content/renderer/render_widget.h (left):
> > 
> >
>
https://codereview.chromium.org/2157113002/diff/1/content/renderer/render_wid...
> > content/renderer/render_widget.h:238: void didFocus() override;
> > We should probably update the comment in render_view_impl.h for didFocus as
> > well.
> 
> Which comment are you referring to? I've moved it to the WebViewClient
> implementation section.

As discussed in chat, I am confused. Please ignore =)

[lfg, 2016-07-19 14:52:01]

lfg@chromium.org changed reviewers:
+ lukasza@chromium.org

[lfg, 2016-07-19 14:52:01]

+lukasza, please take a look on the test runner changes.

[Łukasz Anforowicz, 2016-07-19 15:44:12]

components/test_runner lgtm

[lfg, 2016-07-19 15:46:21]

lfg@chromium.org changed reviewers:
+ jochen@chromium.org

[lfg, 2016-07-19 15:46:21]

+jochen for content/, component/.

[jochen (gone - plz use gerrit), 2016-07-20 09:53:13]

lgtm

[lfg, 2016-07-20 15:16:27]

The CQ bit was checked by lfg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 15:16:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 16:29:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 16:29:36]

Dry run: This issue passed the CQ dry run.

[lfg, 2016-07-20 17:43:26]

The CQ bit was checked by lfg@chromium.org

[lfg, 2016-07-20 17:43:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
lukasza@chromium.org, jochen@chromium.org, dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2157113002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-20 17:44:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 17:50:13]

Description was changed from

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

[commit-bot: I haz the power, 2016-07-20 17:50:14]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 17:50:35]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-20 17:51:56]

Description was changed from

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087
==========

to

==========
Move didFocus from WebWidgetClient to WebViewClient.

This method is used to bring the window to focus, and only makes sense
when called on the main frame.

This is part of a refactor to split WebView/WebWidget.

BUG=419087

Committed: https://crrev.com/09e6b3be2036c2cfbdc625fc06bc928a8c22c60a
Cr-Commit-Position: refs/heads/master@{#406609}
==========

[commit-bot: I haz the power, 2016-07-20 17:51:57]

Patchset 2 (id:??) landed as
https://crrev.com/09e6b3be2036c2cfbdc625fc06bc928a8c22c60a
Cr-Commit-Position: refs/heads/master@{#406609}