Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2157083002: LogDog/Kitchen: Misc fixes. (Closed)

Created:
4 years, 5 months ago by dnj
Modified:
4 years, 5 months ago
Reviewers:
dnj (Google), nodir
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

LogDog/Kitchen: Misc fixes. - Supply the proper Prefix parameter to the Butler instance. - Will no longer strip annotations when teeing. - Allow a user to manually supply the JSON service account file on command-line (useful for debugging). BUG=chromium:628321 TEST=local - Ran locally w/ new flag, observed it correctly sending parameters and streaming! R=nodir@chromium.org Committed: https://chromium.googlesource.com/infra/infra/+/741f18ada910fae7f78ac4ed52e17c828dd36fa3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -15 lines) Patch
M go/src/infra/tools/kitchen/cook_logdog.go View 5 chunks +33 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
dnj (Google)
PTAL
4 years, 5 months ago (2016-07-18 19:36:36 UTC) #2
nodir
lgtm
4 years, 5 months ago (2016-07-18 19:39:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2157083002/1
4 years, 5 months ago (2016-07-18 19:40:29 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 19:56:08 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/741f18ada910fae7f78ac4ed52e17...

Powered by Google App Engine
This is Rietveld 408576698