Consolidate special case shape transformation logic in GrShapeTest.

Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003

Committed: https://skia.googlesource.com/skia/+/487f8d385be2e0dcc7e46339d7bb12e4820b91c8

[bsalomon, 2016-07-18 19:47:23]

Description was changed from

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+stroke->fill for rect geometries in GrShape.
==========

to

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+stroke->fill for rect geometries in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
==========

[bsalomon, 2016-07-18 19:53:09]

Description was changed from

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+stroke->fill for rect geometries in GrShape.
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
==========

to

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
==========

[bsalomon, 2016-07-18 19:53:09]

bsalomon@google.com changed reviewers:
+ robertphillips@google.com

[bsalomon, 2016-07-18 20:00:42]

I'm trying to make it easier to write more "immediately incorporate the style
into a fill path" code paths in GrShape for simple shapes. This is attempting to
consolidate the places where the tests know how the implementation handles these
special cases.

Adding the special case for fill+stroke rects is incidental. It already was
special cased because the path as stroked by the stroker was recognized as a
rect. This made it a different sort of special case for some of the unit tests.
By handling it in GrShape it can be like the rest. This is where I want to head
anyway (and handle more similar cases). Making this test code change forced my
hand into doing it now.

[robertphillips, 2016-07-19 17:36:05]

nits & doc suggestions

I think the result is a lot more comprehensible

https://codereview.chromium.org/2157013003/diff/20001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2157013003/diff/20001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:405: }
shocrtcuts ?

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:440: // These predicates are factored out here to avoid
littering the rest of the
implemantation ?

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:467: template <> bool stroke_is_converted_to_fill(const
SkPath& path) {
// converted to a rect ?

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:477: SkASSERT(paint.getStyle() ==
SkPaint::kStrokeAndFill_Style);
// converted to a bigger rect ?

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:483: if (path_is_axis_aligned_line(path)) {
// converted to a rect ?

[robertphillips, 2016-07-19 17:36:16]

Oh yeah, lgtm

[bsalomon, 2016-07-20 14:00:20]

https://codereview.chromium.org/2157013003/diff/20001/src/gpu/GrShape.cpp
File src/gpu/GrShape.cpp (right):

https://codereview.chromium.org/2157013003/diff/20001/src/gpu/GrShape.cpp#new...
src/gpu/GrShape.cpp:405: }
On 2016/07/19 17:36:05, robertphillips wrote:
> shocrtcuts ?

Done.

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp
File tests/GrShapeTest.cpp (right):

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:440: // These predicates are factored out here to avoid
littering the rest of the
On 2016/07/19 17:36:05, robertphillips wrote:
> implemantation ?

It's like mansplaining.

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:467: template <> bool stroke_is_converted_to_fill(const
SkPath& path) {
On 2016/07/19 17:36:05, robertphillips wrote:
> // converted to a rect ?

Done.

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:477: SkASSERT(paint.getStyle() ==
SkPaint::kStrokeAndFill_Style);
On 2016/07/19 17:36:05, robertphillips wrote:
> // converted to a bigger rect ?

Done.

https://codereview.chromium.org/2157013003/diff/20001/tests/GrShapeTest.cpp#n...
tests/GrShapeTest.cpp:483: if (path_is_axis_aligned_line(path)) {
On 2016/07/19 17:36:05, robertphillips wrote:
> // converted to a rect ?

Done.

[bsalomon, 2016-07-20 14:00:23]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2016-07-20 14:00:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/2157013003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-07-20 14:00:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 14:15:46]

Description was changed from

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003
==========

to

==========
Consolidate special case shape transformation logic in GrShapeTest.

Enable all tests on all geometry types.

Add conversion of fill+miter-stroke->fill for rect geometries in GrShape.

GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2157013003

Committed:
https://skia.googlesource.com/skia/+/487f8d385be2e0dcc7e46339d7bb12e4820b91c8
==========

[commit-bot: I haz the power, 2016-07-20 14:15:47]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/487f8d385be2e0dcc7e46339d7bb12e4820b91c8