Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1775)

Issue 2157013002: Fix DevFS writes with subdirectories (Closed)

Created:
4 years, 5 months ago by Cutch
Modified:
4 years, 5 months ago
Reviewers:
siva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix DevFS writes with subdirectories - [x] Add a test case for multiple level directory DevFS write BUG= R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/1ff0f72158e51dd381b4bf24abf85d76f59af604

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M runtime/bin/vmservice/vmservice_io.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/dev_fs_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Cutch
4 years, 5 months ago (2016-07-18 15:40:31 UTC) #3
siva
lgtm
4 years, 5 months ago (2016-07-18 15:45:19 UTC) #4
Cutch
4 years, 5 months ago (2016-07-18 15:58:46 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ff0f72158e51dd381b4bf24abf85d76f59af604 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698