Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Issue 2156993004: gpu driver bug list: correctly backlist partial swap on Mesa (Closed)

Created:
4 years, 5 months ago by Corentin Wallez
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu driver bug list: correctly backlist partial swap on Mesa This entry previously used "gl_vendor": "Mesa" when the GL_VENDOR string is "Intel Open Source Technology Center". Try to match "Mesa" in the GL_RENDERER string instead. BUG=339493 BUG=628168 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/6bcbbd2886e61691f69ec14c27e62b69f81a271b Cr-Commit-Position: refs/heads/master@{#406194}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Corentin Wallez
PTAL, partial swap fix.
4 years, 5 months ago (2016-07-18 22:32:11 UTC) #3
piman
lgtm
4 years, 5 months ago (2016-07-18 23:24:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156993004/1
4 years, 5 months ago (2016-07-18 23:29:59 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 02:45:37 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 02:45:45 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6bcbbd2886e61691f69ec14c27e62b69f81a271b Cr-Commit-Position: refs/heads/master@{#406194}
4 years, 5 months ago (2016-07-19 02:46:52 UTC) #11
Julien Isorce Samsung
On 2016/07/19 02:46:52, commit-bot: I haz the power wrote: > Patchset 1 (id:??) landed as ...
4 years, 5 months ago (2016-07-19 09:10:31 UTC) #12
Corentin Wallez
4 years, 5 months ago (2016-07-19 13:42:48 UTC) #13
Message was sent while issue was closed.
On 2016/07/19 at 09:10:31, j.isorce wrote:
> On 2016/07/19 02:46:52, commit-bot: I haz the power wrote:
> > Patchset 1 (id:??) landed as
> > https://crrev.com/6bcbbd2886e61691f69ec14c27e62b69f81a271b
> > Cr-Commit-Position: refs/heads/master@{#406194}
> 
> This pending CL would have fix the problem too:
https://codereview.chromium.org/2153373002/
> (Also I think in the commit message you mentioned gl_vendor instead of
driver_vendor :) )

Whoops, I hadn't realized driver_vendor was extracted from the gl_version.

Powered by Google App Engine
This is Rietveld 408576698