Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2156993002: [gn] Fix v8_enable_gdbjit default (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Fix v8_enable_gdbjit default Broke in https://codereview.chromium.org/2116913002/ due to rebase. BUG=chromium:474921 NOTRY=true TBR=jochen@chromium.org, dpranke@chromium.org Committed: https://crrev.com/78f813c1e436da5bbb044a503d75e3c0baae9b8c Cr-Commit-Position: refs/heads/master@{#37841}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build_overrides/v8.gni View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
TBR
4 years, 5 months ago (2016-07-18 14:48:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156993002/1
4 years, 5 months ago (2016-07-18 14:48:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 14:51:46 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/78f813c1e436da5bbb044a503d75e3c0baae9b8c Cr-Commit-Position: refs/heads/master@{#37841}
4 years, 5 months ago (2016-07-18 14:53:14 UTC) #9
Dirk Pranke
4 years, 5 months ago (2016-07-18 16:45:34 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698