Issue 2156973003: Move root_certificates.cc reference out of io_impl_sources.gypi.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2156973003: Move root_certificates.cc reference out of io_impl_sources.gypi. (Closed)

Created:
4 years, 5 months ago by zra

Modified:
4 years, 5 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Move root_certificates.cc reference out of io_impl_sources.gypi. Embedders using GN that don't DEPS in //third_party/root_certificates fail on this file during build file generation because it does not exist. It only needs to be referenced in the gyp build of the standalone embedder for Linux and Windows. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/760cd0157167b49117b0c21986e021d63bc51939

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -1 line)			Patch
	M	runtime/bin/bin.gypi	View		3 chunks	+12 lines, -0 lines	0 comments	Download
	M	runtime/bin/io_impl_sources.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

zra

4 years, 5 months ago (2016-07-20 04:55:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
760cd0157167b49117b0c21986e021d63bc51939 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages