Issue 215693004: Fixing icon ordering problem between browser and running windowed applications

Issue 215693004: Fixing icon ordering problem between browser and running windowed applications (Closed)

Created:
6 years, 9 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 9 months ago

Reviewers:
flackr

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing icon ordering problem between browser and running windowed applications The ordering has recently changed and some alternate shelf layout got not corrected. BUG=346678 TEST=visual testing R=flackr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260187

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

flackr

lgtm with nit https://codereview.chromium.org/215693004/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right): https://codereview.chromium.org/215693004/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc#newcode1884 chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:1884: type == ash::TYPE_BROWSER_SHORTCUT) nit: This should ...

6 years, 9 months ago (2014-03-27 23:21:12 UTC) #2

Mr4D (OOO till 08-26)

thanks! https://codereview.chromium.org/215693004/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc File chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc (right): https://codereview.chromium.org/215693004/diff/1/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc#newcode1884 chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc:1884: type == ash::TYPE_BROWSER_SHORTCUT) On 2014/03/27 23:21:12, flackr wrote: ...

6 years, 9 months ago (2014-03-27 23:24:51 UTC) #3

Mr4D (OOO till 08-26)

The CQ bit was checked by skuhne@chromium.org

6 years, 9 months ago (2014-03-27 23:24:53 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/215693004/20001

6 years, 9 months ago (2014-03-27 23:27:17 UTC) #5

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 9 months ago (2014-03-28 01:19:02 UTC) #6

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel

6 years, 9 months ago (2014-03-28 01:19:02 UTC) #7

Mr4D (OOO till 08-26)

The CQ bit was checked by skuhne@chromium.org

6 years, 9 months ago (2014-03-28 01:51:33 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/215693004/20001

6 years, 9 months ago (2014-03-28 01:52:00 UTC) #9

Mr4D (OOO till 08-26)

6 years, 9 months ago (2014-03-28 17:33:59 UTC) #10

Message was sent while issue was closed.

Committed patchset #2 manually as r260187 (presubmit successful).

Expand Messages | Collapse Messages