Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/android/bookmarks/partner_bookmarks_shim.h

Issue 215693002: [Android] Allow non-editable partner bookmarks. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Forgot to revert sanity-check. Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/bookmarks/partner_bookmarks_shim.h
diff --git a/chrome/browser/android/bookmarks/partner_bookmarks_shim.h b/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
index acb542e386ae4e964c13372a657d230c53b3fe98..9d6fa464aa3ef4ae6cf601ec68c4d464dd52bb0a 100644
--- a/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
+++ b/chrome/browser/android/bookmarks/partner_bookmarks_shim.h
@@ -36,6 +36,14 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data {
// Registers preferences.
static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
+ // Disables the editing and stops any edits from being applied.
+ // The user will start to see the original (unedited) partner bookmarks.
+ // Edits are stored in the user profile, so once the editing is enabled
+ // ("not disabled") the user would see the edited partner bookmarks.
+ // This method should be called as early as possible: it does NOT send any
+ // notifications to already existing shims.
+ static void DisablePartnerBookmarksEditing();
+
// Returns true if everything got loaded.
bool IsLoaded() const;
@@ -46,6 +54,9 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data {
// nor any of its parents were "removed").
bool IsReachable(const BookmarkNode* node) const;
+ // Returns true if a given node is editable and if editing is allowed.
+ bool IsEditable(const BookmarkNode* node) const;
+
// Removes a given bookmark.
// Makes the |node| (and, consequently, all its children) unreachable.
void RemoveBookmark(const BookmarkNode* node);
@@ -104,6 +115,9 @@ class PartnerBookmarksShim : public base::SupportsUserData::Data {
// For testing: clears partner bookmark model data.
static void ClearPartnerModelForTesting();
+ // For testing: re-enables partner bookmarks editing.
+ static void EnablePartnerBookmarksEditing();
+
private:
explicit PartnerBookmarksShim(PrefService* prefs);
virtual ~PartnerBookmarksShim();
« no previous file with comments | « chrome/browser/android/bookmarks/bookmarks_bridge.cc ('k') | chrome/browser/android/bookmarks/partner_bookmarks_shim.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698