[builtins] Introduce a builtin for Abort().

[builtins] Introduce a builtin for Abort().

Calling Runtime::kAbort through a builtin instead of the c-entry stub
will allow to generate the call in a background thread, because a
builtin provides its own handle, whereas a code stub does not.

@v8-mips-ports: Could you take a special look at the padding that is
done in MacroAssembler::Abort()?

R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org, v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com

Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158
Cr-Commit-Position: refs/heads/master@{#37854}

[ahaas, 2016-07-18 08:20:54]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 08:21:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[titzer, 2016-07-18 08:26:40]

lgtm

https://codereview.chromium.org/2156923002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2156923002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:52: ASM(Abort)                                          
                     \
Move comment one line down.

[ahaas, 2016-07-18 08:31:59]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 08:32:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-07-18 08:32:11]

https://codereview.chromium.org/2156923002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2156923002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:52: ASM(Abort)                                          
                     \
On 2016/07/18 at 08:26:40, titzer wrote:
> Move comment one line down.

Done.

[Benedikt Meurer, 2016-07-18 08:39:58]

Thanks, LGTM.

[Michael Starzinger, 2016-07-18 08:51:12]

LGTM.

https://codereview.chromium.org/2156923002/diff/20001/src/arm/macro-assembler...
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/arm/macro-assembler...
src/arm/macro-assembler-arm.cc:2970: Move(r1,
Smi::FromInt(static_cast<int>(reason)));
nit: Empty newline after "Move" for readability.

https://codereview.chromium.org/2156923002/diff/20001/src/builtins/ia32/built...
File src/builtins/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/builtins/ia32/built...
src/builtins/ia32/builtins-ia32.cc:2712: }
nit: empty newline after method for readability.

https://codereview.chromium.org/2156923002/diff/20001/src/ia32/macro-assemble...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/ia32/macro-assemble...
src/ia32/macro-assembler-ia32.cc:2956: Move(edx,
Smi::FromInt(static_cast<int>(reason)));
nit: Empty newline before and after this block for readability.

https://codereview.chromium.org/2156923002/diff/20001/src/mips64/macro-assemb...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/mips64/macro-assemb...
src/mips64/macro-assembler-mips64.cc:6093: Move(a0,
Smi::FromInt(static_cast<int>(reason)));
nit: Empty newline after this block for readability.

https://codereview.chromium.org/2156923002/diff/20001/src/x64/macro-assembler...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/x64/macro-assembler...
src/x64/macro-assembler-x64.cc:640: // Check if Abort() has already been
initialized.
nit: Empty newline before this block for readability.

[ahaas, 2016-07-18 09:02:49]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 09:02:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-07-18 09:04:17]

https://codereview.chromium.org/2156923002/diff/20001/src/arm/macro-assembler...
File src/arm/macro-assembler-arm.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/arm/macro-assembler...
src/arm/macro-assembler-arm.cc:2970: Move(r1,
Smi::FromInt(static_cast<int>(reason)));
On 2016/07/18 at 08:51:11, Michael Starzinger wrote:
> nit: Empty newline after "Move" for readability.

Done

https://codereview.chromium.org/2156923002/diff/20001/src/builtins/ia32/built...
File src/builtins/ia32/builtins-ia32.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/builtins/ia32/built...
src/builtins/ia32/builtins-ia32.cc:2712: }
On 2016/07/18 at 08:51:11, Michael Starzinger wrote:
> nit: empty newline after method for readability.

Done

https://codereview.chromium.org/2156923002/diff/20001/src/ia32/macro-assemble...
File src/ia32/macro-assembler-ia32.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/ia32/macro-assemble...
src/ia32/macro-assembler-ia32.cc:2956: Move(edx,
Smi::FromInt(static_cast<int>(reason)));
On 2016/07/18 at 08:51:11, Michael Starzinger wrote:
> nit: Empty newline before and after this block for readability.

Done

https://codereview.chromium.org/2156923002/diff/20001/src/mips64/macro-assemb...
File src/mips64/macro-assembler-mips64.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/mips64/macro-assemb...
src/mips64/macro-assembler-mips64.cc:6093: Move(a0,
Smi::FromInt(static_cast<int>(reason)));
On 2016/07/18 at 08:51:11, Michael Starzinger wrote:
> nit: Empty newline after this block for readability.

Done

https://codereview.chromium.org/2156923002/diff/20001/src/x64/macro-assembler...
File src/x64/macro-assembler-x64.cc (right):

https://codereview.chromium.org/2156923002/diff/20001/src/x64/macro-assembler...
src/x64/macro-assembler-x64.cc:640: // Check if Abort() has already been
initialized.
On 2016/07/18 at 08:51:11, Michael Starzinger wrote:
> nit: Empty newline before this block for readability.

Done

[commit-bot: I haz the power, 2016-07-18 11:15:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 11:15:44]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[akos.palfi.imgtec, 2016-07-18 22:01:30]

akos.palfi@imgtec.com changed reviewers:
+ akos.palfi@imgtec.com

[akos.palfi.imgtec, 2016-07-18 22:01:31]

MIPS part l-g-t-m.

[ahaas, 2016-07-19 06:58:28]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-07-19 06:58:29]

The patchset sent to the CQ was uploaded after l-g-t-m from titzer@chromium.org,
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2156923002/#ps40001
(title: "Add changes to macro-assembler-mips.cc, and add newlines")

[commit-bot: I haz the power, 2016-07-19 06:58:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ahaas, 2016-07-19 06:58:47]

The CQ bit was unchecked by ahaas@chromium.org

[ahaas, 2016-07-19 07:14:12]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 07:14:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 07:15:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 07:15:51]

Dry run: Try jobs failed on following builders:
  v8_android_arm_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/...)
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/9284)
  v8_linux_arm_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...)
  v8_linux_dbg_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/9252)
  v8_linux_mips64el_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...)
  v8_linux_mipsel_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_linux_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/9226)

[ahaas, 2016-07-19 07:26:45]

The CQ bit was checked by ahaas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-19 07:26:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 08:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-19 08:26:20]

Dry run: This issue passed the CQ dry run.

[ahaas, 2016-07-19 08:28:53]

The CQ bit was checked by ahaas@chromium.org

[ahaas, 2016-07-19 08:28:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org, bmeurer@chromium.org, titzer@chromium.org
Link to the patchset: https://codereview.chromium.org/2156923002/#ps80001
(title: "Rebase")

[commit-bot: I haz the power, 2016-07-19 08:29:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-19 08:31:23]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-07-19 08:31:26]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-19 08:33:26]

Description was changed from

==========
[builtins] Introduce a builtin for Abort().

Calling Runtime::kAbort through a builtin instead of the c-entry stub
will allow to generate the call in a background thread, because a
builtin provides its own handle, whereas a code stub does not.

@v8-mips-ports: Could you take a special look at the padding that is
done in MacroAssembler::Abort()?

R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org,
v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com
==========

to

==========
[builtins] Introduce a builtin for Abort().

Calling Runtime::kAbort through a builtin instead of the c-entry stub
will allow to generate the call in a background thread, because a
builtin provides its own handle, whereas a code stub does not.

@v8-mips-ports: Could you take a special look at the padding that is
done in MacroAssembler::Abort()?

R=bmeurer@chromium.org, titzer@chromium.org, mstarzinger@chromium.org,
v8-mips-ports@googlegroups.com, v8-arm-ports@googlegroups.com

Committed: https://crrev.com/9be015a254cfff871c56cd129523a729637e9158
Cr-Commit-Position: refs/heads/master@{#37854}
==========

[commit-bot: I haz the power, 2016-07-19 08:33:28]

Patchset 5 (id:??) landed as
https://crrev.com/9be015a254cfff871c56cd129523a729637e9158
Cr-Commit-Position: refs/heads/master@{#37854}

[Michael Hablich, 2016-07-20 07:21:57]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2163603003/ by hablich@chromium.org.

The reason for reverting is: Blocks roll:
https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%....