Creates alertCoordinatorDelegate for alerts

ios/chrome/browser/ui/alert_coordinator/action_sheet.h

Index: ios/chrome/browser/ui/alert_coordinator/action_sheet.h
diff --git a/ios/chrome/browser/ui/alert_coordinator/action_sheet.h b/ios/chrome/browser/ui/alert_coordinator/action_sheet.h
new file mode 100644
index 0000000000000000000000000000000000000000..59dda27ee44df7726278dba4cf0388244de92038
--- /dev/null
+++ b/ios/chrome/browser/ui/alert_coordinator/action_sheet.h
@@ -0,0 +1,26 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef IOS_CHROME_BROWSER_UI_ALERT_COORDINATOR_ACTION_SHEET_H_
+#define IOS_CHROME_BROWSER_UI_ALERT_COORDINATOR_ACTION_SHEET_H_
+
+#import <UIKit/UIKit.h>
+
+#import "ios/chrome/browser/ui/alert_coordinator/alert_coordinator.h"
+
+namespace web {
+struct ContextMenuParams;
+}
+
+// Delegate for the AlertCoordinator, charged with displaying context menus for
+// all device form factors. Will show a sheet on the phone and use a popover on

[michaeldo, 2016/07/18 15:29:07]

ContextMenuParams shouldn't be used anywhere in this alert_coordinator
directory. Only the specialized ContextMenuCoordinator should use it. There is
some conflicting terminology here. web::ContextMenuParams is specifically used
to store values needed to display a "web site context menu" that is triggered
when the user long presses on a link.

It sounds like AlertCoordinator is a much more generic class than that so we
shouldn't make it dependent on the ContextMenuParams type.

+// a tablet.
+@interface ActionSheet : NSObject<AlertCoordinatorDelegate>

[lpromero, 2016/07/18 12:11:35]

I don't like the names of these new classes. What do you think of
ActionSheetDelegate and AlertDelegate?

[gambard, 2016/07/18 12:40:20]

I was concerned about misunderstanding "ActionSheetDelegate" for "a delegate for
an ActionSheet". If you think it is OK, I will change them.

[lpromero, 2016/07/18 12:51:43]

As per a comment here:
https://codereview.chromium.org/2154163002/diff/1/ios/chrome/browser/ui/conte...
could we even hide these classes from clients?

[marq (ping after 24h), 2016/07/18 13:02:41]

ObjC *classes* shouldn't be named 'Delegate', since that's conventionally used
for a particular kind of protocol.

I think this class is really an 'ActionSheetContentAdaptor', since it's exposing
web::ContextmenuParams in a way that another object that consumes ActionSheet
content information can use.

+
+// Initializes with details provided in |params|.
+- (instancetype)initWithParams:(const web::ContextMenuParams&)params;

[marq (ping after 24h), 2016/07/18 13:02:41]

 NS_DESIGNATED_INITIALIZER, and mark the regular -init NS_UNAVAILABLE.

+
+@end
+
+#endif  // IOS_CHROME_BROWSER_UI_ALERT_COORDINATOR_ACTION_SHEET_H_