Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(461)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2156883003: MD Settings: About page, remove unnecessary two-line CSS class. (Closed)

Created:
4 years, 5 months ago by dpapad
Modified:
4 years, 5 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: About page, remove unnecessary two-line CSS class. BUG=628878 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/b8c16c8de1f6e2df2ebc01c1a36b675ae6b0b2d3 Cr-Commit-Position: refs/heads/master@{#406090}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/resources/settings/about_page/about_page.html View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
dpapad
4 years, 5 months ago (2016-07-18 17:58:03 UTC) #3
michaelpg
lgtm https://codereview.chromium.org/2156883003/diff/1/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2156883003/diff/1/chrome/browser/resources/settings/about_page/about_page.html#newcode135 chrome/browser/resources/settings/about_page/about_page.html:135: actionable> nit: remove wrap?
4 years, 5 months ago (2016-07-18 18:32:18 UTC) #4
dpapad
https://codereview.chromium.org/2156883003/diff/1/chrome/browser/resources/settings/about_page/about_page.html File chrome/browser/resources/settings/about_page/about_page.html (right): https://codereview.chromium.org/2156883003/diff/1/chrome/browser/resources/settings/about_page/about_page.html#newcode135 chrome/browser/resources/settings/about_page/about_page.html:135: actionable> On 2016/07/18 at 18:32:18, michaelpg wrote: > nit: ...
4 years, 5 months ago (2016-07-18 18:48:45 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156883003/20001
4 years, 5 months ago (2016-07-18 18:49:46 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-18 21:04:23 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:04:52 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:05:50 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/b8c16c8de1f6e2df2ebc01c1a36b675ae6b0b2d3
Cr-Commit-Position: refs/heads/master@{#406090}

Powered by Google App Engine
This is Rietveld 408576698