Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2156873002: Invalidate resolution if a unit instantiate a class with the unnamed constructor change. (Closed)

Created:
4 years, 5 months ago by scheglov
Modified:
4 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Invalidate resolution if a unit instantiate a class with the unnamed constructor change. This invalidates more often than it should. We could refined it later to invalidate only if the instantiation is with the unnamed constructor only. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/6cd42f56655885b57ac6fff70c070e6144c52c5a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -1 line) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +12 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/incremental_element_builder.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/context/context_test.dart View 2 chunks +202 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/incremental_element_builder_test.dart View 4 chunks +65 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 5 months ago (2016-07-17 06:01:05 UTC) #1
Brian Wilkerson
lgtm
4 years, 5 months ago (2016-07-18 13:54:44 UTC) #2
scheglov
4 years, 5 months ago (2016-07-18 15:38:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cd42f56655885b57ac6fff70c070e6144c52c5a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698