Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/platform/plugins/PluginData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index 887326eada4986fe5c4b1e09664b26df0716726a..9bc1f111be617b18510f0db6ad4de735ffa0e6b8 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -229,10 +229,7 @@ void Page::setNeedsRecalcStyleInAllFrames()
void Page::refreshPlugins()
{
- if (allPages().isEmpty())
- return;
-
- PluginData::refresh();
+ PluginData::refreshBrowserSidePluginCache();
for (const Page* page : allPages()) {
// Clear out the page's plugin data.
@@ -241,10 +238,10 @@ void Page::refreshPlugins()
}
}
-PluginData* Page::pluginData() const
+PluginData* Page::pluginData(SecurityOrigin* mainFrameOrigin) const
{
- if (!m_pluginData)
- m_pluginData = PluginData::create(this);
+ if (!m_pluginData || !mainFrameOrigin->isSameSchemeHostPort(m_pluginData->origin()))
+ m_pluginData = PluginData::create(mainFrameOrigin);
return m_pluginData.get();
}
« no previous file with comments | « third_party/WebKit/Source/core/page/Page.h ('k') | third_party/WebKit/Source/platform/plugins/PluginData.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698