Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: content/browser/frame_host/render_frame_message_filter.cc

Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/frame_host/render_frame_message_filter.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/render_frame_message_filter.cc
diff --git a/content/browser/frame_host/render_frame_message_filter.cc b/content/browser/frame_host/render_frame_message_filter.cc
index 07dc9d561d4bb0e4a574b6d3bf4f142e9392980f..9bcb84dfdcade5ea37cd48fa4fd99fd8177a288d 100644
--- a/content/browser/frame_host/render_frame_message_filter.cc
+++ b/content/browser/frame_host/render_frame_message_filter.cc
@@ -452,6 +452,7 @@ void RenderFrameMessageFilter::GetCookies(int render_frame_id,
void RenderFrameMessageFilter::OnGetPlugins(
bool refresh,
+ const url::Origin& main_frame_origin,
IPC::Message* reply_msg) {
// Don't refresh if the specified threshold has not been passed. Note that
// this check is performed before off-loading to the file thread. The reason
@@ -470,12 +471,14 @@ void RenderFrameMessageFilter::OnGetPlugins(
}
}
- PluginServiceImpl::GetInstance()->GetPlugins(base::Bind(
- &RenderFrameMessageFilter::GetPluginsCallback, this, reply_msg));
+ PluginServiceImpl::GetInstance()->GetPlugins(
+ base::Bind(&RenderFrameMessageFilter::GetPluginsCallback, this, reply_msg,
+ main_frame_origin));
}
void RenderFrameMessageFilter::GetPluginsCallback(
IPC::Message* reply_msg,
+ const url::Origin& main_frame_origin,
const std::vector<WebPluginInfo>& all_plugins) {
// Filter the plugin list.
PluginServiceFilter* filter = PluginServiceImpl::GetInstance()->GetFilter();
@@ -483,15 +486,16 @@ void RenderFrameMessageFilter::GetPluginsCallback(
int child_process_id = -1;
int routing_id = MSG_ROUTING_NONE;
+ GURL policy_url =
+ main_frame_origin.unique() ? GURL() : GURL(main_frame_origin.Serialize());
// In this loop, copy the WebPluginInfo (and do not use a reference) because
// the filter might mutate it.
for (WebPluginInfo plugin : all_plugins) {
- if (!filter || filter->IsPluginAvailable(child_process_id,
- routing_id,
- resource_context_,
- GURL(),
- GURL(),
- &plugin)) {
+ // TODO(crbug.com/621724): Pass an url::Origin instead of a GURL.
+ if (!filter ||
+ filter->IsPluginAvailable(child_process_id, routing_id,
+ resource_context_, policy_url, policy_url,
+ &plugin)) {
plugins.push_back(plugin);
}
}
« no previous file with comments | « content/browser/frame_host/render_frame_message_filter.h ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698