third_party/WebKit/Source/platform/plugins/PluginData.h - Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/plugins/PluginData.h

Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Reload plugin list and send message with an url whenever origin changes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_message_filter.h ('K') | « third_party/WebKit/Source/core/page/Page.cpp ('k') | third_party/WebKit/Source/platform/plugins/PluginData.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/plugins/PluginData.h

diff --git a/third_party/WebKit/Source/platform/plugins/PluginData.h b/third_party/WebKit/Source/platform/plugins/PluginData.h

index 1b881edf451e85ec65e9111e20cd1694754773a9..2c47ae1a38ea456ae368f3f6fb16ba73a759f9ed 100644

--- a/third_party/WebKit/Source/platform/plugins/PluginData.h

+++ b/third_party/WebKit/Source/platform/plugins/PluginData.h

@@ -21,6 +21,7 @@

#define PluginData_h

#include "platform/PlatformExport.h"

+#include "public/platform/WebSecurityOrigin.h"

#include "wtf/Noncopyable.h"

#include "wtf/RefCounted.h"

#include "wtf/Vector.h"

@@ -28,7 +29,6 @@

namespace blink {

-class Page;

struct PluginInfo;

struct MimeClassInfo {

@@ -52,7 +52,7 @@ struct PluginInfo {

class PLATFORM_EXPORT PluginData : public RefCounted<PluginData> {

WTF_MAKE_NONCOPYABLE(PluginData);

public:

- static PassRefPtr<PluginData> create(const Page* page) { return adoptRef(new PluginData(page)); }

+ static PassRefPtr<PluginData> create(const WebSecurityOrigin& origin) { return adoptRef(new PluginData(origin)); }

const Vector<PluginInfo>& plugins() const { return m_plugins; }

const Vector<MimeClassInfo>& mimes() const { return m_mimes; }

@@ -60,17 +60,20 @@ public:

bool supportsMimeType(const String& mimeType) const;

String pluginNameForMimeType(const String& mimeType) const;

+ void checkOriginChange(const WebSecurityOrigin&);

static void refresh();

+ static bool m_refresh;

private:

- explicit PluginData(const Page*);

- void initPlugins(const Page*);

+ explicit PluginData(const WebSecurityOrigin&);

+ void initPlugins(const WebSecurityOrigin&);

const PluginInfo* pluginInfoForMimeType(const String& mimeType) const;

Vector<PluginInfo> m_plugins;

Vector<MimeClassInfo> m_mimes;

Vector<size_t> m_mimePluginIndices;

+ WebSecurityOrigin m_origin;

tommycli 2016/07/29 23:38:19 my suggestion: Don't save m_origin here. Save it o

trizzofo 2016/08/01 23:36:14 Done.

};

// Checks if any of the plugins handle this extension, and if so returns the