third_party/WebKit/Source/core/dom/DOMImplementation.cpp - Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes per alexmos@'s comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/test/test_blink_web_unit_test_support.cc ('k') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('j') | third_party/WebKit/Source/core/frame/LocalFrame.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/DOMImplementation.cpp

diff --git a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

index 5c7975e2c94c5fb777ecb1d96de93c7e7abc6cf0..1d086d986a2b7664bc0c3a378baecd394a3ea6fb 100644

--- a/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

+++ b/third_party/WebKit/Source/core/dom/DOMImplementation.cpp

@@ -225,9 +225,9 @@ Document* DOMImplementation::createDocument(const String& type, const DocumentIn

if (type == "application/xhtml+xml")

return XMLDocument::createXHTML(init);

- PluginData* pluginData = 0;

+ PluginData* pluginData = nullptr;

if (init.frame() && init.frame()->page() && init.frame()->loader().allowPlugins(NotAboutToInstantiatePlugin))

- pluginData = init.frame()->pluginData();

+ pluginData = init.frame()->page()->pluginData(init.owner() ? init.owner()->getSecurityOrigin() : SecurityOrigin::create(init.url()).get());

// PDF is one image type for which a plugin can override built-in support.

// We do not want QuickTime to take over all image types, obviously.