content/common/frame_messages.h - Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/frame_messages.h

Issue 2156803002: [HBD] Remove PluginCache and reload plugin list when origin changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address issues pointed in comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/frame_host/render_frame_message_filter.cc ('K') | « content/browser/frame_host/render_frame_message_filter.cc ('k') | content/ppapi_plugin/ppapi_blink_platform_impl.h » ('j') | content/renderer/renderer_blink_platform_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/frame_messages.h

diff --git a/content/common/frame_messages.h b/content/common/frame_messages.h

index 27f9af77f4335908c0e1e95aeec9369ea35acc22..c56f1d7c3ee5492f972bb36b84a3d47eb6a1c5a5 100644

--- a/content/common/frame_messages.h

+++ b/content/common/frame_messages.h

@@ -1224,9 +1224,10 @@ IPC_MESSAGE_ROUTED1(FrameHostMsg_PepperStopsPlayback,

int32_t /* pp_instance */)

// Used to get the list of plugins

alexmos 2016/08/02 22:06:28 nit: update this comment to explain what the main_

trizzofo 2016/08/03 00:08:37 Done.

-IPC_SYNC_MESSAGE_CONTROL1_1(FrameHostMsg_GetPlugins,

- bool /* refresh*/,

- std::vector<content::WebPluginInfo> /* plugins */)

+IPC_SYNC_MESSAGE_CONTROL2_1(FrameHostMsg_GetPlugins,

+ bool /* refresh*/,

+ url::Origin /* main_frame_origin */,

+ std::vector<content::WebPluginInfo> /* plugins */)

// Return information about a plugin for the given URL and MIME

// type. If there is no matching plugin, |found| is false.