[HBD] Remove PluginCache and reload plugin list when origin changes

third_party/WebKit/Source/core/dom/DOMImplementation.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ skipping 207 matching lines @@
 {
     if (inViewSourceMode)
         return HTMLViewSourceDocument::create(init, type);
 
     // Plugins cannot take HTML and XHTML from us, and we don't even need to initialize the plugin database for those.
     if (type == "text/html")
         return HTMLDocument::create(init);
     if (type == "application/xhtml+xml")
         return XMLDocument::createXHTML(init);
 
-    PluginData* pluginData = 0;
+    PluginData* pluginData = nullptr;
     if (init.frame() && init.frame()->page() && init.frame()->loader().allowPlugins(NotAboutToInstantiatePlugin))
-        pluginData = init.frame()->pluginData();
+        pluginData = init.frame()->page()->pluginData(init.frame()->isMainFrame() ? SecurityOrigin::create(init.url()).get() : init.frame()->tree().top()->securityContext()->getSecurityOrigin());

[esprehn, 2016/08/29 20:54:56]

why not always call tree().top() ?

Calling .get() on the PassRefPtr here is bad, the object is left floating.

You want to save a local variable if you want to do that.

[trizzofo, 2016/08/29 21:32:32]

When the document is being created for the main frame,
init.frame()->tree().top->securityContext() returns nullptr, because the
document is cleared in installNewDocument() (createDocument() caller). So we
need to get the origin directly from init.url().
Done.

 
     // PDF is one image type for which a plugin can override built-in support.
     // We do not want QuickTime to take over all image types, obviously.
     if ((type == "application/pdf" || type == "text/pdf") && pluginData && pluginData->supportsMimeType(type))
         return PluginDocument::create(init);
     // multipart/x-mixed-replace is only supported for images.
     if (Image::supportsType(type) || type == "multipart/x-mixed-replace")
         return ImageDocument::create(init);
 
     // Check to see if the type can be played by our media player, if so create a MediaDocument
@@ skipping 14 matching lines @@
 
     return HTMLDocument::create(init);
 }
 
 DEFINE_TRACE(DOMImplementation)
 {
     visitor->trace(m_document);
 }
 
 } // namespace blink