Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: content/test/gpu/page_sets/pixel_tests.py

Issue 2156793002: Add a pixel test for CSS filter effects. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Nit extra period. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/test/gpu/gpu_tests/pixel_expectations.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/test/gpu/page_sets/pixel_tests.py
diff --git a/content/test/gpu/page_sets/pixel_tests.py b/content/test/gpu/page_sets/pixel_tests.py
index e95007fe858b2b243cd51a34e08546e17f6ac67e..6643bd4505929906daba3808a784f7ab5483ccaf 100644
--- a/content/test/gpu/page_sets/pixel_tests.py
+++ b/content/test/gpu/page_sets/pixel_tests.py
@@ -53,6 +53,14 @@ class WebGLNonChromiumImageSharedPageState(gpu_test_base.GpuSharedPageState):
['--disable-webgl-image-chromium'])
+class DisableMacOverlaysSharedPageState(gpu_test_base.GpuSharedPageState):
+ def __init__(self, test, finder_options, story_set):
+ super(DisableMacOverlaysSharedPageState, self).__init__(
+ test, finder_options, story_set)
+ finder_options.browser_options.AppendExtraBrowserArgs(
+ ['--disable-mac-overlays'])
+
+
class PixelTestsStorySet(story_set_module.StorySet):
""" Some basic test cases for GPU. """
@@ -125,6 +133,25 @@ class PixelTestsStorySet(story_set_module.StorySet):
shared_page_state_class=WebGLNonChromiumImageSharedPageState,
expectations=expectations))
+ # On macOS, test CSS filter effects with and without the CA compositor.
+ self.AddStory(PixelTestsPage(
+ url='file://../../data/gpu/filter_effects.html',
+ name=base_name + '.CSSFilterEffects',
+ test_rect=[0, 0, 300, 300],
+ revision=1,
+ story_set=self,
+ shared_page_state_class=gpu_test_base.GpuSharedPageState,
+ expectations=expectations))
+
+ self.AddStory(PixelTestsPage(
+ url='file://../../data/gpu/filter_effects.html',
+ name=base_name + '.CSSFilterEffects.NoOverlays',
+ test_rect=[0, 0, 300, 300],
+ revision=1,
+ story_set=self,
+ shared_page_state_class=DisableMacOverlaysSharedPageState,
+ expectations=expectations))
+
def _AddAllPages(self, expectations, base_name, use_es3):
if use_es3:
es3_suffix = 'ES3'
« no previous file with comments | « content/test/gpu/gpu_tests/pixel_expectations.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698