Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2156793002: Add a pixel test for CSS filter effects. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a pixel test for CSS filter effects. The test has 10 squares filled with a color gradient. 10 different filter effects are applied to each square. The filter effects are applied with a keyframe animation to force the non-display list path. BUG=581526 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/0c5d9012e90c6a3dbad7c9a475cf26205b2d1a44 Cr-Commit-Position: refs/heads/master@{#406095}

Patch Set 1 #

Patch Set 2 : Need to figure out why non-animation filter effects not triggering GL compositor. #

Patch Set 3 : Cleanup. #

Patch Set 4 : Nit extra period. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -0 lines) Patch
A content/test/data/gpu/filter_effects.html View 1 2 1 chunk +117 lines, -0 lines 0 comments Download
M content/test/gpu/gpu_tests/pixel_expectations.py View 1 1 chunk +4 lines, -0 lines 0 comments Download
M content/test/gpu/page_sets/pixel_tests.py View 1 2 3 2 chunks +27 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
erikchen
piman: Please review.
4 years, 5 months ago (2016-07-18 19:57:18 UTC) #6
piman
lgtm
4 years, 5 months ago (2016-07-18 20:16:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156793002/60001
4 years, 5 months ago (2016-07-18 20:18:38 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 5 months ago (2016-07-18 21:11:21 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 21:11:35 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 21:12:25 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/0c5d9012e90c6a3dbad7c9a475cf26205b2d1a44
Cr-Commit-Position: refs/heads/master@{#406095}

Powered by Google App Engine
This is Rietveld 408576698