extensions/browser/api/web_request/web_request_api.cc - Issue 2156763003: Extend the webRequest.onCompleted event details object with TLS/SSL information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2156763003: Extend the webRequest.onCompleted event details object with TLS/SSL information Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove questionably useful fields & add feature switch Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/browser/api/web_request/web_request_api.cc

diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc

index 5e27be4d2efcf9c713eca44705d4a47abbac738f..76e02b441558016b3d1ad49e93ae133db392d42f 100644

--- a/extensions/browser/api/web_request/web_request_api.cc

+++ b/extensions/browser/api/web_request/web_request_api.cc

@@ -55,6 +55,7 @@

#include "extensions/common/error_utils.h"

#include "extensions/common/event_filtering_info.h"

#include "extensions/common/extension.h"

+#include "extensions/common/feature_switch.h"

#include "extensions/common/features/feature.h"

#include "extensions/common/permissions/permissions_data.h"

#include "extensions/common/url_pattern.h"

@@ -908,6 +909,9 @@ void ExtensionWebRequestEventRouter::OnCompleted(

CreateEventDetails(request, extra_info_spec));

event_details->SetResponseHeaders(request, request->response_headers());

event_details->SetResponseSource(request);

+ if (FeatureSwitch::webrequest_ssl_info()->IsEnabled() &&

+ request->ssl_info().is_valid())

+ event_details->SetSSLInfo(request);

DispatchEvent(browser_context, request, listeners, std::move(event_details));

}

« no previous file with comments | « AUTHORS ('k') | extensions/browser/api/web_request/web_request_api_constants.h » ('j') | extensions/common/api/web_request.json » ('J')