extensions/browser/api/web_request/web_request_event_details.h - Issue 2156763003: Extend the webRequest.onCompleted event details object with TLS/SSL information

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/web_request/web_request_event_details.h

Issue 2156763003: Extend the webRequest.onCompleted event details object with TLS/SSL information Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Consistently use key constants for dict fields and simplify validation error reporting Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/browser/api/web_request/web_request_api_helpers.cc ('K') | « extensions/browser/api/web_request/web_request_api_helpers.cc ('k') | extensions/browser/api/web_request/web_request_event_details.cc » ('j') | extensions/browser/api/web_request/web_request_event_details.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/web_request/web_request_event_details.h

diff --git a/extensions/browser/api/web_request/web_request_event_details.h b/extensions/browser/api/web_request/web_request_event_details.h

index 5eb14cb2a85d8461ee0b32ab875dc970d2f89409..3a79de30fd57b5fccf20208bc31dd8311fb4d129 100644

--- a/extensions/browser/api/web_request/web_request_event_details.h

+++ b/extensions/browser/api/web_request/web_request_event_details.h

@@ -77,6 +77,10 @@ class WebRequestEventDetails {

// - ip

void SetResponseSource(const net::URLRequest* request);

+ // Sets the following key:

+ // - keys::kSSLInfoKey

+ void SetSSLInfo(const net::URLRequest* request);

void SetBoolean(const std::string& key, bool value) {

dict_.SetBoolean(key, value);

}