Extend the webRequest.onCompleted event details object with TLS/SSL information

extensions/browser/api/web_request/web_request_api_helpers.h

Index: extensions/browser/api/web_request/web_request_api_helpers.h
diff --git a/extensions/browser/api/web_request/web_request_api_helpers.h b/extensions/browser/api/web_request/web_request_api_helpers.h
index fae87e724ae8931d27dbd89c23cae47e6b006112..4b88e6bea60503b58afb84dcfd2d1596dc18c7ff 100644
--- a/extensions/browser/api/web_request/web_request_api_helpers.h
+++ b/extensions/browser/api/web_request/web_request_api_helpers.h
@@ -19,8 +19,10 @@
 #include "content/public/common/resource_type.h"
 #include "extensions/browser/warning_set.h"
 #include "net/base/auth.h"
+#include "net/cert/x509_certificate.h"

[Ryan Sleevi, 2017/01/31 21:37:56]

You're forward declaring this; you don't need to include it.

 #include "net/http/http_request_headers.h"
 #include "net/http/http_response_headers.h"
+#include "net/ssl/ssl_info.h"

[Ryan Sleevi, 2017/01/31 21:37:56]

This is not used

 #include "url/gurl.h"
 
 namespace base {
@@ -34,6 +36,7 @@ class Extension;
 
 namespace net {
 class NetLogWithSource;
+class X509Certificate;
 }
 
 namespace extension_web_request_api_helpers {
@@ -343,6 +346,11 @@ const char* ResourceTypeToString(content::ResourceType type);
 bool ParseResourceType(const std::string& type_str,
                        std::vector<content::ResourceType>* types);
 
+// Returns a list of dictionaries containing various information about the chain
+// of certificates referenced by |cert|. Ownership is passed to the caller.
+base::ListValue* ExtractCertificateChain(

[Ryan Sleevi, 2017/01/31 21:37:56]

Because "ownership is passed to the caller", you should be encapsulating this in
a std::unique_ptr

std::unique_ptr<base::ListValue> ExtractCertificateChain(...)

+    scoped_refptr<net::X509Certificate> cert);

[Ryan Sleevi, 2017/01/31 21:37:56]

Because you're *not* passing ownership (or holding a reference to this), you
should be passing this as a naked pointer.

net::X509Certificate* cert

+
 }  // namespace extension_web_request_api_helpers
 
 #endif  // EXTENSIONS_BROWSER_API_WEB_REQUEST_WEB_REQUEST_API_HELPERS_H_