Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: extensions/browser/api/web_request/web_request_api.cc

Issue 2156763003: Extend the webRequest.onCompleted event details object with TLS/SSL information Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Consistently use key constants for dict fields and simplify validation error reporting Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/web_request_api.cc
diff --git a/extensions/browser/api/web_request/web_request_api.cc b/extensions/browser/api/web_request/web_request_api.cc
index 8f2d6fdbdb1d0f1ad3e7130a50e2485d28bf4c39..815f226bc8b28e3e6446ecdb4a7b29a009f4a3bc 100644
--- a/extensions/browser/api/web_request/web_request_api.cc
+++ b/extensions/browser/api/web_request/web_request_api.cc
@@ -59,6 +59,7 @@
#include "extensions/common/error_utils.h"
#include "extensions/common/event_filtering_info.h"
#include "extensions/common/extension.h"
+#include "extensions/common/feature_switch.h"
#include "extensions/common/features/feature.h"
#include "extensions/common/permissions/permissions_data.h"
#include "extensions/common/url_pattern.h"
@@ -957,6 +958,9 @@ void ExtensionWebRequestEventRouter::OnCompleted(
CreateEventDetails(request, extra_info_spec));
event_details->SetResponseHeaders(request, request->response_headers());
event_details->SetResponseSource(request);
+ if (FeatureSwitch::webrequest_ssl_info()->IsEnabled() &&
+ request->ssl_info().is_valid())
Ryan Sleevi 2017/01/31 21:37:56 Braces
+ event_details->SetSSLInfo(request);
DispatchEvent(browser_context, request, listeners, navigation_ui_data,
std::move(event_details));

Powered by Google App Engine
This is Rietveld 408576698