Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: subprocess2.py

Issue 215673002: Improve error message in subprocess2.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # coding=utf8 1 # coding=utf8
2 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 2 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 """Collection of subprocess wrapper functions. 5 """Collection of subprocess wrapper functions.
6 6
7 In theory you shouldn't need anything else in subprocess, or this module failed. 7 In theory you shouldn't need anything else in subprocess, or this module failed.
8 """ 8 """
9 9
10 import cStringIO 10 import cStringIO
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 # Convert fork() emulation failure into a CygwinRebaseError(). 240 # Convert fork() emulation failure into a CygwinRebaseError().
241 raise CygwinRebaseError( 241 raise CygwinRebaseError(
242 e.errno, 242 e.errno,
243 args, 243 args,
244 kwargs.get('cwd'), 244 kwargs.get('cwd'),
245 None, 245 None,
246 'Visit ' 246 'Visit '
247 'http://code.google.com/p/chromium/wiki/CygwinDllRemappingFailure ' 247 'http://code.google.com/p/chromium/wiki/CygwinDllRemappingFailure '
248 'to learn how to fix this error; you need to rebase your cygwin ' 248 'to learn how to fix this error; you need to rebase your cygwin '
249 'dlls') 249 'dlls')
250 # Popen() can throw OSError when cwd or args[0] doesn't exist. Let it go 250 # Popen() can throw OSError when cwd or args[0] doesn't exist.
251 # through 251 raise OSError('%s or %s probably doesn\'t exist' %
252 raise 252 (kwargs.get('cwd'), args[0]))
253 253
254 def _tee_threads(self, input): # pylint: disable=W0622 254 def _tee_threads(self, input): # pylint: disable=W0622
255 """Does I/O for a process's pipes using threads. 255 """Does I/O for a process's pipes using threads.
256 256
257 It's the simplest and slowest implementation. Expect very slow behavior. 257 It's the simplest and slowest implementation. Expect very slow behavior.
258 258
259 If there is a callback and it doesn't keep up with the calls, the timeout 259 If there is a callback and it doesn't keep up with the calls, the timeout
260 effectiveness will be delayed accordingly. 260 effectiveness will be delayed accordingly.
261 """ 261 """
262 # Queue of either of <threadname> when done or (<threadname>, data). In 262 # Queue of either of <threadname> when done or (<threadname>, data). In
(...skipping 242 matching lines...) Expand 10 before | Expand all | Expand 10 after
505 505
506 - Throws if return code is not 0. 506 - Throws if return code is not 0.
507 - Works even prior to python 2.7. 507 - Works even prior to python 2.7.
508 - Blocks stdin by default if not specified since no output will be visible. 508 - Blocks stdin by default if not specified since no output will be visible.
509 - As per doc, "The stdout argument is not allowed as it is used internally." 509 - As per doc, "The stdout argument is not allowed as it is used internally."
510 """ 510 """
511 kwargs.setdefault('stdin', VOID) 511 kwargs.setdefault('stdin', VOID)
512 if 'stdout' in kwargs: 512 if 'stdout' in kwargs:
513 raise ValueError('stdout argument not allowed, it will be overridden.') 513 raise ValueError('stdout argument not allowed, it will be overridden.')
514 return check_call_out(args, stdout=PIPE, **kwargs)[0] 514 return check_call_out(args, stdout=PIPE, **kwargs)[0]
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698