[Chromoting] Implement DualBufferFrameConsumer

remoting/client/software_video_renderer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/software_video_renderer.h"
 
 #include <utility>
 
 #include "base/bind.h"
 #include "base/callback.h"
@@ skipping 33 matching lines @@
 }
 
 }  // namespace
 
 SoftwareVideoRenderer::SoftwareVideoRenderer(protocol::FrameConsumer* consumer)
     : consumer_(consumer), weak_factory_(this) {
   thread_checker_.DetachFromThread();
 }
 
 SoftwareVideoRenderer::SoftwareVideoRenderer(
+    std::unique_ptr<protocol::FrameConsumer> consumer)
+    : owned_consumer_(std::move(consumer)),

[Sergey Ulanov, 2016/07/20 18:39:26]

nit: I think it's better to call the other constructor here and then initialize
owner_consumer_ in the body of the constructor. That would allow to avoid
duplication of the initializer list and the DetachFromThread() call.

[Yuwei, 2016/07/21 00:07:32]

Done.

+      consumer_(owned_consumer_.get()),
+      weak_factory_(this) {
+  thread_checker_.DetachFromThread();
+}
+
+SoftwareVideoRenderer::SoftwareVideoRenderer(
     scoped_refptr<base::SingleThreadTaskRunner> decode_task_runner,
     protocol::FrameConsumer* consumer,
     protocol::FrameStatsConsumer* stats_consumer)
     : decode_task_runner_(decode_task_runner),
       consumer_(consumer),
       stats_consumer_(stats_consumer),
       weak_factory_(this) {}
 
 SoftwareVideoRenderer::~SoftwareVideoRenderer() {
   if (decoder_)
@@ skipping 123 matching lines @@
 
   stats->client_stats.time_rendered = base::TimeTicks::Now();
   if (stats_consumer_)
     stats_consumer_->OnVideoFrameStats(*stats);
 
   if (!done.is_null())
     done.Run();
 }
 
 }  // namespace remoting