Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 21567003: cc: Fix accelerated video freezing with commit aborts (Closed)

Created:
7 years, 4 months ago by enne (OOO)
Modified:
7 years, 4 months ago
Reviewers:
danakj
CC:
chromium-reviews, feature-media-reviews_chromium.org, cc-bugs_chromium.org, Mallinath (Gone from Chromium), tnakamura
Visibility:
Public.

Description

cc: Fix accelerated video freezing with commit aborts Although VideoLayer doesn't update any resources, it needs to not let commits abort when it has been invalidated as this is currently the mechanism on desktop to tell the compositor to redraw it with a new frame. R=danakj@chromium.org BUG=266350 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215169

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add test; update comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
M cc/layers/video_layer.h View 1 chunk +2 lines, -0 lines 0 comments Download
M cc/layers/video_layer.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 1 3 chunks +52 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
enne (OOO)
7 years, 4 months ago (2013-08-01 20:19:14 UTC) #1
danakj
LGTM test? https://codereview.chromium.org/21567003/diff/1/cc/layers/video_layer.cc File cc/layers/video_layer.cc (right): https://codereview.chromium.org/21567003/diff/1/cc/layers/video_layer.cc#newcode30 cc/layers/video_layer.cc:30: // TODO(enne): Have the video frame provider ...
7 years, 4 months ago (2013-08-01 20:22:01 UTC) #2
danakj
https://codereview.chromium.org/21567003/diff/1/cc/layers/video_layer.cc File cc/layers/video_layer.cc (right): https://codereview.chromium.org/21567003/diff/1/cc/layers/video_layer.cc#newcode30 cc/layers/video_layer.cc:30: // TODO(enne): Have the video frame provider communicate this ...
7 years, 4 months ago (2013-08-01 20:22:54 UTC) #3
enne (OOO)
Added a test, removed TODO and left a better comment.
7 years, 4 months ago (2013-08-01 21:02:15 UTC) #4
danakj
LGTM! Thanks!
7 years, 4 months ago (2013-08-01 21:04:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/21567003/7001
7 years, 4 months ago (2013-08-01 21:07:46 UTC) #6
commit-bot: I haz the power
7 years, 4 months ago (2013-08-02 00:36:43 UTC) #7
Message was sent while issue was closed.
Change committed as 215169

Powered by Google App Engine
This is Rietveld 408576698