Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: components/sync/js/README.js

Issue 2156693002: [Sync] //components/sync internal changes [DO NOT SUBMIT] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/sync/js/DEPS ('k') | components/sync/js/js_backend.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 This framework was once used to implement an asynchronous request/reply 5 This framework was once used to implement an asynchronous request/reply
6 protocol between the chrome://sync-internals page and the sync backend thread. 6 protocol between the chrome://sync-internals page and the sync backend thread.
7 Much of it has been removed in favor of an ad-hoc system that allows us to 7 Much of it has been removed in favor of an ad-hoc system that allows us to
8 offer better safety guarantees, and to dispatch requests to different threads. 8 offer better safety guarantees, and to dispatch requests to different threads.
9 9
10 All that remains are some WeakHandles that allow us to send JsEvents from the 10 All that remains are some WeakHandles that allow us to send JsEvents from the
11 sync backend to about:sync. The SyncInternalsUI implements JsEventHandler in 11 sync backend to about:sync. The SyncInternalsUI implements JsEventHandler in
12 order to receive these events. The SyncManager implements JsBackend in order 12 order to receive these events. The SyncManager implements JsBackend in order
13 to send them. The SyncJsController acts as an intermediary between them. 13 to send them. The SyncJsController acts as an intermediary between them.
14 14
15 The old framework may still be useful to someone. Feel free to retrieve it 15 The old framework may still be useful to someone. Feel free to retrieve it
16 from SVN history if you feel you can make use of it. 16 from SVN history if you feel you can make use of it.
OLDNEW
« no previous file with comments | « components/sync/js/DEPS ('k') | components/sync/js/js_backend.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698