Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(451)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2156663002: DevTools: Change a few implicit globals to explicit globals. (Closed)

Created:
4 years, 5 months ago by paulirish
Modified:
4 years, 5 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman, sergeyv+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Change a few implicit globals to explicit globals. Committed: https://crrev.com/a2ea2ed6b18a582f34efe40245d5df075b5bceb3 Cr-Commit-Position: refs/heads/master@{#406633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHost.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (5 generated)
paulirish
This is required for nodejs compatibility
4 years, 5 months ago (2016-07-15 19:06:06 UTC) #2
pfeldman
lgtm
4 years, 5 months ago (2016-07-18 18:27:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156663002/1
4 years, 5 months ago (2016-07-18 18:28:32 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/264383)
4 years, 5 months ago (2016-07-18 19:49:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156663002/1
4 years, 5 months ago (2016-07-20 17:29:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 19:09:36 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 19:09:46 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 19:11:01 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a2ea2ed6b18a582f34efe40245d5df075b5bceb3
Cr-Commit-Position: refs/heads/master@{#406633}

Powered by Google App Engine
This is Rietveld 408576698