Move ~1000 SpdySerializedFrame instances from heap to stack in tests.

Move ~1000 SpdySerializedFrame instances from heap to stack in tests.

* Return SpdySerializedFrame instead of SpdySerializedFrame* in SpdyTestUtil.
* Move ~1000 SpdySerializedFrame local variables from heap to stack in tests,
  thus eliminating ~1000 unnecessary memory allocations.
* Remove unused SpdyTestUtil::ConstructSpdyFrame() methods.
* s/SpdyTestUtil::ConstructSpdyBodyFrame/SpdyTestUtil::ConstructSpdyDataFrame/
  (Body is an application layer concept; data is a framing layer concept.)
* Use SpdyTestUtil::ConstructSpdyDataFrame() instead of
  BufferedSpdyFramer::CreateDataFrame() in tests;
  remove unused BufferedSpdyFramer instances.
* Remove one unused unique_ptr<SpdySerializedFrame> instance from
  BidirectionalStreamTest.CancelStreamDuringReadData.

This change only affects tests, there is no functional change intended, and
there is no move semantics involved.

BUG=600438
Committed: https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584
Cr-Commit-Position: refs/heads/master@{#405845}

[Bence, 2016-07-15 18:14:26]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 18:14:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 19:33:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 19:33:48]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-07-15 19:58:06]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2016-07-15 19:58:06]

Helen: PTAL.  Thank you.

[xunjieli, 2016-07-15 20:13:40]

The code is so much cleaner! + 1 to the change. lgtm

[Bence, 2016-07-15 20:22:22]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-07-15 20:22:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 20:27:58]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-15 20:29:50]

Description was changed from

==========
Move ~1000 SpdySerializedFrame instances from heap to stack in tests.

* Return SpdySerializedFrame instead of SpdySerializedFrame* in SpdyTestUtil.
* Move ~1000 SpdySerializedFrame local variables from heap to stack in tests,
  thus eliminating ~1000 unnecessary memory allocations.
* Remove unused SpdyTestUtil::ConstructSpdyFrame() methods.
* s/SpdyTestUtil::ConstructSpdyBodyFrame/SpdyTestUtil::ConstructSpdyDataFrame/
  (Body is an application layer concept; data is a framing layer concept.)
* Use SpdyTestUtil::ConstructSpdyDataFrame() instead of
  BufferedSpdyFramer::CreateDataFrame() in tests;
  remove unused BufferedSpdyFramer instances.
* Remove one unused unique_ptr<SpdySerializedFrame> instance from
  BidirectionalStreamTest.CancelStreamDuringReadData.

This change only affects tests, there is no functional change intended, and
there is no move semantics involved.

BUG=600438
==========

to

==========
Move ~1000 SpdySerializedFrame instances from heap to stack in tests.

* Return SpdySerializedFrame instead of SpdySerializedFrame* in SpdyTestUtil.
* Move ~1000 SpdySerializedFrame local variables from heap to stack in tests,
  thus eliminating ~1000 unnecessary memory allocations.
* Remove unused SpdyTestUtil::ConstructSpdyFrame() methods.
* s/SpdyTestUtil::ConstructSpdyBodyFrame/SpdyTestUtil::ConstructSpdyDataFrame/
  (Body is an application layer concept; data is a framing layer concept.)
* Use SpdyTestUtil::ConstructSpdyDataFrame() instead of
  BufferedSpdyFramer::CreateDataFrame() in tests;
  remove unused BufferedSpdyFramer instances.
* Remove one unused unique_ptr<SpdySerializedFrame> instance from
  BidirectionalStreamTest.CancelStreamDuringReadData.

This change only affects tests, there is no functional change intended, and
there is no move semantics involved.

BUG=600438

Committed: https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584
Cr-Commit-Position: refs/heads/master@{#405845}
==========

[commit-bot: I haz the power, 2016-07-15 20:29:51]

Patchset 1 (id:??) landed as
https://crrev.com/df80d44fd869b5a27871be4c5c1e0fdfd184d584
Cr-Commit-Position: refs/heads/master@{#405845}