Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1018)

Issue 2156633003: Add entry to mb_config.pyl for Linux layout test try bot with flag --enable-slimming-paint-v2. (Closed)

Created:
4 years, 5 months ago by qyearsley
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke, pdr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add entry to mb_config.pyl for Linux layout test try bot with flag --enable-slimming-paint-v2. This just adds an entry to mb_config.pyl; the rest of the config for this builder is in http://crrev.com/2153503006. BUG=622865 Committed: https://crrev.com/3ecbe5a338fe2d0ad7376e4a820fe097c8c8df4d Cr-Commit-Position: refs/heads/master@{#406726}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Removed extra blank line; added entry in sorted order. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/mb/mb_config.pyl View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
qyearsley
4 years, 5 months ago (2016-07-15 22:24:02 UTC) #3
Dirk Pranke
lgtm w/ changes addressed. https://codereview.chromium.org/2156633003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2156633003/diff/1/tools/mb/mb_config.pyl#newcode764 tools/mb/mb_config.pyl:764: nit: remove this random blank ...
4 years, 5 months ago (2016-07-15 22:29:56 UTC) #4
qyearsley
Can this be committed before http://crrev.com/2153503006? https://codereview.chromium.org/2156633003/diff/1/tools/mb/mb_config.pyl File tools/mb/mb_config.pyl (right): https://codereview.chromium.org/2156633003/diff/1/tools/mb/mb_config.pyl#newcode764 tools/mb/mb_config.pyl:764: On 2016/07/15 at ...
4 years, 5 months ago (2016-07-15 22:37:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156633003/20001
4 years, 5 months ago (2016-07-20 23:26:38 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 00:27:05 UTC) #9
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 00:28:40 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3ecbe5a338fe2d0ad7376e4a820fe097c8c8df4d
Cr-Commit-Position: refs/heads/master@{#406726}

Powered by Google App Engine
This is Rietveld 408576698