Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2156583002: Check for method.returns_promise around ExceptionState::throwIfNeeded (Closed)

Created:
4 years, 5 months ago by jgruber
Modified:
4 years, 5 months ago
Reviewers:
haraken
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check for method.returns_promise around ExceptionState::throwIfNeeded This ensures that either an exception is thrown, or a promise is rejected, never both. BUG=628526 Committed: https://crrev.com/894f497bb8a3bf00a32a396abae1a6e91824867d Cr-Commit-Position: refs/heads/master@{#405967}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M third_party/WebKit/Source/bindings/templates/methods.cpp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
jgruber
4 years, 5 months ago (2016-07-15 13:00:10 UTC) #4
haraken
LGTM
4 years, 5 months ago (2016-07-15 14:19:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2156583002/1
4 years, 5 months ago (2016-07-18 06:37:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-18 08:53:38 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-18 08:53:41 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-18 08:55:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/894f497bb8a3bf00a32a396abae1a6e91824867d
Cr-Commit-Position: refs/heads/master@{#405967}

Powered by Google App Engine
This is Rietveld 408576698