Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2156523003: [DevTools] Fix links for JSFrame records in timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 561ed3398a1fbe0a0ec4071f291fc7efa0ecdc50..20683a89828aa6f364eb6561559a0a662ee00a1b 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -84,9 +84,18 @@ WebInspector.TimelineTreeView.prototype = {
* @param {!RuntimeAgent.CallFrame} frame
* @return {?Element}
*/
+ _linkifyLocationForTracing: function(frame)
+ {
+ return this._linkifier.maybeLinkifyConsoleCallFrameForTracing(this._model.target(), frame);
+ },
+
+ /**
+ * @param {!RuntimeAgent.CallFrame} frame
+ * @return {?Element}
+ */
linkifyLocation: function(frame)
{
- return this._linkifier.maybeLinkifyConsoleCallFrameForTimeline(this._model.target(), frame);
+ return this._linkifier.maybeLinkifyConsoleCallFrame(this._model.target(), frame);
},
/**
@@ -347,7 +356,9 @@ WebInspector.TimelineTreeView.GridNode.prototype = {
var frame = WebInspector.TimelineProfileTree.eventStackFrame(event);
if (frame && frame["url"]) {
var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (frame);
- var link = this._treeView.linkifyLocation(callFrame);
+ var link = event.name === WebInspector.TimelineModel.RecordType.JSFrame
+ ? this._treeView.linkifyLocation(callFrame)
+ : this._treeView._linkifyLocationForTracing(callFrame);
if (link)
container.createChild("div", "activity-link").appendChild(link);
}

Powered by Google App Engine
This is Rietveld 408576698