Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js

Issue 2156523003: [DevTools] Fix links for JSFrame records in timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
index 21471d7924f7a6ca14ebe64eaa8873000ce5ac8c..304615cfed1c1905257931831b752a4c01813bb9 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js
@@ -84,9 +84,18 @@ WebInspector.TimelineTreeView.prototype = {
* @param {!RuntimeAgent.CallFrame} frame
* @return {!Element}
*/
+ linkifyLocationForTracing: function(frame)
alph 2016/07/18 19:49:21 nit: Make it private.
kozy 2016/07/18 22:57:22 Done.
+ {
+ return this._linkifier.linkifyConsoleCallFrameForTracing(this._model.target(), frame);
+ },
+
+ /**
+ * @param {!RuntimeAgent.CallFrame} frame
+ * @return {!Element}
+ */
linkifyLocation: function(frame)
{
- return this._linkifier.linkifyConsoleCallFrameForTimeline(this._model.target(), frame);
+ return this._linkifier.linkifyConsoleCallFrame(this._model.target(), frame);
},
/**
@@ -347,7 +356,10 @@ WebInspector.TimelineTreeView.GridNode.prototype = {
var frame = WebInspector.TimelineProfileTree.eventStackFrame(event);
if (frame && frame["url"]) {
var callFrame = /** @type {!RuntimeAgent.CallFrame} */ (frame);
- container.createChild("div", "activity-link").appendChild(this._treeView.linkifyLocation(callFrame));
+ var linkifiedLocation = event.name === WebInspector.TimelineModel.RecordType.JSFrame
+ ? this._treeView.linkifyLocation(callFrame)
+ : this._treeView.linkifyLocationForTracing(callFrame);
+ container.createChild("div", "activity-link").appendChild(linkifiedLocation);
}
icon.style.backgroundColor = WebInspector.TimelineUIUtils.eventColor(event);
}

Powered by Google App Engine
This is Rietveld 408576698