Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2156523003: [DevTools] Fix links for JSFrame records in timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 { 222 {
223 return this.maybeLinkifyScriptLocation(target, callFrame.scriptId, callF rame.url, callFrame.lineNumber, callFrame.columnNumber, classes); 223 return this.maybeLinkifyScriptLocation(target, callFrame.scriptId, callF rame.url, callFrame.lineNumber, callFrame.columnNumber, classes);
224 }, 224 },
225 225
226 /** 226 /**
227 * @param {?WebInspector.Target} target 227 * @param {?WebInspector.Target} target
228 * @param {!RuntimeAgent.CallFrame} callFrame 228 * @param {!RuntimeAgent.CallFrame} callFrame
229 * @param {string=} classes 229 * @param {string=} classes
230 * @return {?Element} 230 * @return {?Element}
231 */ 231 */
232 maybeLinkifyConsoleCallFrameForTimeline: function(target, callFrame, classes ) 232 maybeLinkifyConsoleCallFrameForTracing: function(target, callFrame, classes)
233 { 233 {
234 // TODO(kozyatinskiy): remove this when Profilers will migrate to 0-base d lineNumber and columnNumber. 234 // TODO(kozyatinskiy): remove this when tracing will migrate to 0-based lineNumber and columnNumber.
235 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes); 235 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);
236 }, 236 },
237 237
238 /** 238 /**
239 * @param {!WebInspector.Target} target 239 * @param {!WebInspector.Target} target
240 * @param {!RuntimeAgent.StackTrace} stackTrace 240 * @param {!RuntimeAgent.StackTrace} stackTrace
241 * @param {string=} classes 241 * @param {string=} classes
242 * @return {!Element} 242 * @return {!Element}
243 */ 243 */
244 linkifyStackTraceTopFrame: function(target, stackTrace, classes) 244 linkifyStackTraceTopFrame: function(target, stackTrace, classes)
(...skipping 322 matching lines...) Expand 10 before | Expand all | Expand 10 after
567 /** 567 /**
568 * @param {!WebInspector.NetworkRequest} request 568 * @param {!WebInspector.NetworkRequest} request
569 * @return {!Element} 569 * @return {!Element}
570 */ 570 */
571 WebInspector.linkifyRequestAsNode = function(request) 571 WebInspector.linkifyRequestAsNode = function(request)
572 { 572 {
573 var anchor = WebInspector.linkifyURLAsNode(request.url); 573 var anchor = WebInspector.linkifyURLAsNode(request.url);
574 anchor.requestId = request.requestId; 574 anchor.requestId = request.requestId;
575 return anchor; 575 return anchor;
576 } 576 }
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698