[DevTools] Fix links for JSFrame records in timeline

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 547 matching lines @@
     case recordType.XHRReadyStateChange:
     case recordType.XHRLoad:
     case recordType.ResourceSendRequest:
     case recordType.ResourceReceivedData:
     case recordType.ResourceReceiveResponse:
     case recordType.ResourceFinish:
         if (event.url)
             details = WebInspector.linkifyResourceAsNode(event.url);
         break;
     case recordType.FunctionCall:
-        details = linkifyLocation(eventData["scriptId"], eventData["scriptName"], eventData["scriptLine"], 0);
+        details = linkifyLocation(eventData["scriptId"], eventData["scriptName"], eventData["scriptLine"] - 1, 0);
         break;
     case recordType.JSFrame:
         details = createElement("span");
         details.createTextChild(WebInspector.beautifyFunctionName(eventData["functionName"]));
         var location = linkifyLocation(eventData["scriptId"], eventData["url"], eventData["lineNumber"], eventData["columnNumber"]);
         if (location) {
             details.createTextChild(" @ ");
             details.appendChild(location);
         }
         break;
     case recordType.CompileScript:
     case recordType.EvaluateScript:
         var url = eventData["url"];
         if (url)
-            details = linkifyLocation("", url, eventData["lineNumber"], 0);
+            details = linkifyLocation("", url, eventData["lineNumber"] - 1, 0);
         break;
     case recordType.ParseScriptOnBackground:
         var url = eventData["url"];
         if (url)
             details = linkifyLocation("", url, 0, 0);
         break;
     default:
         if (event.hasCategory(WebInspector.TimelineModel.Category.Console))
             detailsText = null;
         else
             details = linkifyTopCallFrame();
         break;
     }
 
     if (!details && detailsText)
         details = createTextNode(detailsText);
     return details;
 
     /**
      * @param {string} scriptId
      * @param {string} url
      * @param {number} lineNumber
      * @param {number=} columnNumber
      */
     function linkifyLocation(scriptId, url, lineNumber, columnNumber)
     {
-        // FIXME(62725): stack trace line/column numbers are one-based.
-        if (columnNumber)
-            --columnNumber;
-        return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber - 1, columnNumber, "timeline-details");
+        return linkifier.linkifyScriptLocation(target, scriptId, url, lineNumber, columnNumber, "timeline-details");
     }
 
     /**
      * @return {?Element}
      */
     function linkifyTopCallFrame()
     {
         var frame = WebInspector.TimelineUIUtils.topStackFrame(event);
-        return frame ? linkifier.linkifyConsoleCallFrameForTimeline(target, frame, "timeline-details") : null;
+        return frame ? linkifier.linkifyConsoleCallFrameForTracing(target, frame, "timeline-details") : null;

[alph, 2016/07/16 01:33:36]

I think this can be a "tracing" frame as well as a "profiler" frame.

[kozy, 2016/07/16 04:54:04]

I think that all frames from profiler have JSFrame type. linkifyTopCallFrame is
called once in default case of switch that contains separate case for
recordType.JSFrame.

     }
 }
 
 /**
  * @param {!WebInspector.TracingModel.Event} event
  * @param {!WebInspector.TimelineModel} model
  * @param {!WebInspector.Linkifier} linkifier
  * @param {boolean} detailed
  * @param {function(!DocumentFragment)} callback
  */
@@ skipping 356 matching lines @@
         var priority = WebInspector.uiLabelForPriority(/** @type {!NetworkAgent.ResourcePriority} */ (request.priority));
         contentHelper.appendTextRow(WebInspector.UIString("Priority"), priority);
     }
     if (request.mimeType)
         contentHelper.appendTextRow(WebInspector.UIString("Mime Type"), request.mimeType);
 
     var title = WebInspector.UIString("Initiator");
     var sendRequest = request.children[0];
     var topFrame = WebInspector.TimelineUIUtils.topStackFrame(sendRequest);
     if (topFrame) {
-        contentHelper.appendElementRow(title, linkifier.linkifyConsoleCallFrameForTimeline(target, topFrame));
+        contentHelper.appendElementRow(title, linkifier.linkifyConsoleCallFrameForTracing(target, topFrame));
     } else if (sendRequest.initiator) {
         var initiatorURL = WebInspector.TimelineUIUtils.eventURL(sendRequest.initiator);
         if (initiatorURL)
             contentHelper.appendElementRow(title, linkifier.linkifyScriptLocation(target, null, initiatorURL, 0));
     }
 
     /**
      * @param {function(?Element)} fulfill
      */
     function action(fulfill)
@@ skipping 224 matching lines @@
         else
             title.createTextChild(WebInspector.UIString("Unknown cause for "));
 
         this._appendTruncatedNodeList(title, this._invalidations);
 
         if (topFrame && this._contentHelper.linkifier()) {
             title.createTextChild(WebInspector.UIString(". "));
             var stack = title.createChild("span", "monospace");
             stack.createChild("span").textContent = WebInspector.beautifyFunctionName(topFrame.functionName);
             stack.createChild("span").textContent = " @ ";
-            stack.createChild("span").appendChild(this._contentHelper.linkifier().linkifyConsoleCallFrameForTimeline(target, topFrame));
+            stack.createChild("span").appendChild(this._contentHelper.linkifier().linkifyConsoleCallFrameForTracing(target, topFrame));
         }
 
         return title;
     },
 
     /**
      * @override
      */
     onpopulate: function()
     {
@@ skipping 883 matching lines @@
     case warnings.V8Deopt:
         span.appendChild(WebInspector.linkifyURLAsNode("https://github.com/GoogleChrome/devtools-docs/issues/53",
             WebInspector.UIString("Not optimized"), undefined, true));
         span.createTextChild(WebInspector.UIString(": %s", eventData["deoptReason"]));
         break;
     default:
         console.assert(false, "Unhandled TimelineModel.WarningType");
     }
     return span;
 }