Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/components/Linkifier.js

Issue 2156523003: [DevTools] Fix links for JSFrame records in timeline (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 { 206 {
207 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber, callFrame.columnNumber, classes); 207 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber, callFrame.columnNumber, classes);
208 }, 208 },
209 209
210 /** 210 /**
211 * @param {?WebInspector.Target} target 211 * @param {?WebInspector.Target} target
212 * @param {!RuntimeAgent.CallFrame} callFrame 212 * @param {!RuntimeAgent.CallFrame} callFrame
213 * @param {string=} classes 213 * @param {string=} classes
214 * @return {!Element} 214 * @return {!Element}
215 */ 215 */
216 linkifyConsoleCallFrameForTimeline: function(target, callFrame, classes) 216 linkifyConsoleCallFrameForTracing: function(target, callFrame, classes)
217 { 217 {
218 // TODO(kozyatinskiy): remove this when Profilers will migrate to 0-base d lineNumber and columnNumber. 218 // TODO(kozyatinskiy): remove this when tracing will migrate to 0-based lineNumber and columnNumber.
alph 2016/07/18 19:49:21 I's prefer that once an object is claimed to be a
kozy 2016/07/18 22:57:22 Acknowledged.
219 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes); 219 return this.linkifyScriptLocation(target, callFrame.scriptId, callFrame. url, callFrame.lineNumber - 1, callFrame.columnNumber - 1, classes);
220 }, 220 },
221 221
222 /** 222 /**
223 * @param {!WebInspector.Target} target 223 * @param {!WebInspector.Target} target
224 * @param {!RuntimeAgent.StackTrace} stackTrace 224 * @param {!RuntimeAgent.StackTrace} stackTrace
225 * @param {string=} classes 225 * @param {string=} classes
226 * @return {!Element} 226 * @return {!Element}
227 */ 227 */
228 linkifyStackTraceTopFrame: function(target, stackTrace, classes) 228 linkifyStackTraceTopFrame: function(target, stackTrace, classes)
(...skipping 317 matching lines...) Expand 10 before | Expand all | Expand 10 after
546 /** 546 /**
547 * @param {!WebInspector.NetworkRequest} request 547 * @param {!WebInspector.NetworkRequest} request
548 * @return {!Element} 548 * @return {!Element}
549 */ 549 */
550 WebInspector.linkifyRequestAsNode = function(request) 550 WebInspector.linkifyRequestAsNode = function(request)
551 { 551 {
552 var anchor = WebInspector.linkifyURLAsNode(request.url); 552 var anchor = WebInspector.linkifyURLAsNode(request.url);
553 anchor.requestId = request.requestId; 553 anchor.requestId = request.requestId;
554 return anchor; 554 return anchor;
555 } 555 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698